From 6b55a9e515276c7e7d2956c7da06cdd67e46d96c Mon Sep 17 00:00:00 2001 From: Joe Robertson Date: Fri, 20 Feb 2026 14:25:53 -0700 Subject: [PATCH 1/2] Change ScaledCoolingCapacity to ScaledHeatingCapacity in SizingManager check for FractionOfAutosizedHeatingCapacity. --- src/EnergyPlus/SizingManager.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/EnergyPlus/SizingManager.cc b/src/EnergyPlus/SizingManager.cc index ca0e0e31aac..94d85106921 100644 --- a/src/EnergyPlus/SizingManager.cc +++ b/src/EnergyPlus/SizingManager.cc @@ -5105,7 +5105,7 @@ void GetZoneHVACSizing(EnergyPlusData &state) state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true; } if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity < 0.0 && - state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) { + state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity != AutoSize) { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Illegal {} = {:.7T}", From 176069474e767475a21f613d10e3978571a61ae3 Mon Sep 17 00:00:00 2001 From: Joe Robertson Date: Mon, 23 Feb 2026 09:47:40 -0700 Subject: [PATCH 2/2] Remove several error checks on DesignSpecification:ZoneHVAC:Sizing fields that are already protected by the IDD. --- src/EnergyPlus/SizingManager.cc | 70 --------------------------------- 1 file changed, 70 deletions(-) diff --git a/src/EnergyPlus/SizingManager.cc b/src/EnergyPlus/SizingManager.cc index 94d85106921..2d3f44bb61a 100644 --- a/src/EnergyPlus/SizingManager.cc +++ b/src/EnergyPlus/SizingManager.cc @@ -4981,14 +4981,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) { state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true; } - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity < 0.0 && - state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError( - state, - format("Illegal {} = {:.7T}", cNumericFields(iCoolDesignCapacityNumericNum), Numbers(iCoolDesignCapacityNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum))); @@ -4999,21 +4991,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) state.dataSize->ZoneHVACSizing(zSIndex).CoolingCapMethod = CapacityPerFloorArea; if (!lNumericBlanks(iCoolCapacityPerFloorAreaNumericNum)) { state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity = Numbers(iCoolCapacityPerFloorAreaNumericNum); - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity <= 0.0) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum))); - ShowContinueError(state, - format("Illegal {} = {:.7T}", - cNumericFields(iCoolCapacityPerFloorAreaNumericNum), - Numbers(iCoolCapacityPerFloorAreaNumericNum))); - ErrorsFound = true; - // Autosized input is not allowed - } else if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum))); - ShowContinueError(state, format("Illegal {} = Autosize", cNumericFields(iCoolCapacityPerFloorAreaNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum))); @@ -5024,18 +5001,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) state.dataSize->ZoneHVACSizing(zSIndex).CoolingCapMethod = FractionOfAutosizedCoolingCapacity; if (!lNumericBlanks(iCoolFracOfAutosizedCapacityNumericNum)) { state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity = Numbers(iCoolFracOfAutosizedCapacityNumericNum); - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity == AutoSize) { - state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true; - } - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity < 0.0 && - state.dataSize->ZoneHVACSizing(zSIndex).ScaledCoolingCapacity != AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, - format("Illegal {} = {:.7T}", - cNumericFields(iCoolFracOfAutosizedCapacityNumericNum), - Numbers(iCoolFracOfAutosizedCapacityNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iCoolCAPMAlphaNum), Alphas(iCoolCAPMAlphaNum))); @@ -5058,14 +5023,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) { state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true; } - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity < 0.0 && - state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity != AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError( - state, - format("Illegal {} = {:.7T}", cNumericFields(iHeatDesignCapacityNumericNum), Numbers(iHeatDesignCapacityNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum))); @@ -5076,21 +5033,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) state.dataSize->ZoneHVACSizing(zSIndex).HeatingCapMethod = CapacityPerFloorArea; if (!lNumericBlanks(iHeatCapacityPerFloorAreaNumericNum)) { state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity = Numbers(iHeatCapacityPerFloorAreaNumericNum); - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity <= 0.0) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum))); - ShowContinueError(state, - format("Illegal {} = {:.7T}", - cNumericFields(iHeatCapacityPerFloorAreaNumericNum), - Numbers(iHeatCapacityPerFloorAreaNumericNum))); - ErrorsFound = true; - // Autosized input is not allowed - } else if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum))); - ShowContinueError(state, format("Illegal {} = Autosize", cNumericFields(iHeatCapacityPerFloorAreaNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum))); @@ -5101,18 +5043,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) state.dataSize->ZoneHVACSizing(zSIndex).HeatingCapMethod = FractionOfAutosizedHeatingCapacity; if (!lNumericBlanks(iHeatFracOfAutosizedCapacityNumericNum)) { state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity = Numbers(iHeatFracOfAutosizedCapacityNumericNum); - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity == AutoSize) { - state.dataSize->ZoneHVACSizing(zSIndex).RequestAutoSize = true; - } - if (state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity < 0.0 && - state.dataSize->ZoneHVACSizing(zSIndex).ScaledHeatingCapacity != AutoSize) { - ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); - ShowContinueError(state, - format("Illegal {} = {:.7T}", - cNumericFields(iHeatFracOfAutosizedCapacityNumericNum), - Numbers(iHeatFracOfAutosizedCapacityNumericNum))); - ErrorsFound = true; - } } else { ShowSevereError(state, format("{} = {}", CurrentModuleObject, state.dataSize->ZoneHVACSizing(zSIndex).Name)); ShowContinueError(state, format("Input for {} = {}", cAlphaFields(iHeatCAPMAlphaNum), Alphas(iHeatCAPMAlphaNum)));