From e1b58485919dcff639feee8beab8d40f54baaffb Mon Sep 17 00:00:00 2001 From: Julien Marrec Date: Thu, 13 Nov 2025 22:22:11 +0100 Subject: [PATCH 1/3] Fix autosize hvac --- model/simulationtests/autosize_hvac.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/model/simulationtests/autosize_hvac.rb b/model/simulationtests/autosize_hvac.rb index 3d570901..ad461a6b 100644 --- a/model/simulationtests/autosize_hvac.rb +++ b/model/simulationtests/autosize_hvac.rb @@ -391,8 +391,16 @@ def make_tes_coil(model) wwhp = OpenStudio::Model::HeatPumpWaterToWaterEquationFitCooling.new(model) chw_loop.addSupplyBranchForComponent(wwhp) cw_loop.addDemandBranchForComponent(wwhp) + chw_storage = OpenStudio::Model::ThermalStorageChilledWaterStratified.new(model) chw_storage.setSetpointTemperatureSchedule(chw_temp_sch) +chw_storage.setTankRecoveryTime(4.0) +chw_storage.waterHeaterSizing.setTimeforTankRecovery(4.0) +chw_storage.autosizeSourceSideDesignFlowRate +chw_storage.autosizeNominalCoolingCapacity +chw_storage.autosizeUseSideDesignFlowRate +chw_storage.autocalculateSourceSideOutletHeight +chw_storage.autocalculateUseSideInletHeight chw_loop.addSupplyBranchForComponent(chw_storage) storage_loop.addDemandBranchForComponent(chw_storage) From fdb09469f48e565f087559835570ee0b14ab3ed8 Mon Sep 17 00:00:00 2001 From: Julien Marrec Date: Thu, 13 Nov 2025 22:38:24 +0100 Subject: [PATCH 2/3] Ignore a few things --- test_helpers.rb | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/test_helpers.rb b/test_helpers.rb index 320d2b3e..055ff9bb 100644 --- a/test_helpers.rb +++ b/test_helpers.rb @@ -982,7 +982,18 @@ def autosizing_test(filename, weather_file = nil, model_measures = [], energyplu ], 'OS:HeatPump:AirToWater:FuelFired:Heating' => [ 'autosizedDesignTemperatureLift' # E+ is missing it - ] + ], + 'OS:EvaporativeFluidCooler:SingleSpeed' => [ + 'autosizedDesignEnteringWaterTemperature' # E+ is missing it + ], + 'OS:EvaporativeFluidCooler:TwoSpeed' => [ + 'autosizedDesignEnteringWaterTemperature' # E+ is missing it + ], + # TODO: temp + 'OS:HeatPump:AirToWater:Heating' => 'all', # Not in test model + 'OS:HeatPump:AirToWater:Cooling' => 'all', # Not in test model + 'OS:HeatPump:AirToWater:Heating:SpeedData' => 'all', # Not in test model + 'OS:HeatPump:AirToWater:Cooling:SpeedData' => 'all' # Not in test model } # Aliases for some OS onjects From e3eaf9af17270b5d94ccbee4390de382308a964f Mon Sep 17 00:00:00 2001 From: "github-rubocop-actions[bot]" Date: Thu, 13 Nov 2025 22:01:42 +0000 Subject: [PATCH 3/3] Commit rubocop --auto-correct (Ruby ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux], Rubocop 1.50.0) --- test_helpers.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test_helpers.rb b/test_helpers.rb index 055ff9bb..e926af6e 100644 --- a/test_helpers.rb +++ b/test_helpers.rb @@ -176,15 +176,15 @@ def get_cli_subcommand_from_env(sdk_version_str, debug: false) $IntersectDir = File.join($RootDir, 'model/intersectiontests/') $IntersectFile = File.join($RootDir, 'intersect.rb.erb') -if !ENV['TEST_DIR'].nil? +if ENV['TEST_DIR'].nil? + $TestDir = File.join($RootDir, 'testruns') +else $TestDir = ENV.fetch('TEST_DIR', 'testruns') # If it's a relative path, make it absolute if File.expand_path($TestDir) != $TestDir $TestDir = File.join($RootDir, $TestDir) end puts "Setting TestDir to #{$TestDir}" -else - $TestDir = File.join($RootDir, 'testruns') end $SddSimDir = File.join($RootDir, 'model/sddtests/')