Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace optional NPM dependency webworker-threads with web-worker #17

Open
onlyurei opened this issue Nov 6, 2021 · 3 comments
Open

Comments

@onlyurei
Copy link

onlyurei commented Nov 6, 2021

Looks like webworker-threads is not maintained anymore, and the author recommends to use web-worker instead:
audreyt/node-webworker-threads#204
audreyt/node-webworker-threads#206

@Hugo-ter-Doest
Copy link

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here:
https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js
Is that what you mean?

I can replace it with webworker.

@onlyurei
Copy link
Author

onlyurei commented Nov 7, 2021

I don't see a dependency here on webworker-threads. I think you mean the dependency in NaturalNode, here: https://github.com/NaturalNode/natural/blob/master/lib/natural/classifiers/classifier_train_parallel.js Is that what you mean?

I can replace it with webworker.

@Hugo-ter-Doest Yes, sorry I opened the issue in the wrong repo - was trying to understand the e2e flow of NB classification class.

@Hugo-ter-Doest
Copy link

I will ook into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants