Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextjs 13 peer dep 이슈 #45

Closed
ttppggnnss opened this issue Jul 1, 2024 · 4 comments · Fixed by #46
Closed

nextjs 13 peer dep 이슈 #45

ttppggnnss opened this issue Jul 1, 2024 · 4 comments · Fixed by #46
Assignees

Comments

@ttppggnnss
Copy link

ttppggnnss commented Jul 1, 2024

@byhhh2 @yceffort-naver
안녕하세요
nextjs 13 및 react 18 관련해서 아래와 같은 Peer deps 이슈가 있는 것 같습니다
확인 부탁드려도 될까요? 🙇‍♂️

image

image

@yceffort-naver
Copy link

@byhhh2 @yceffort-naver

@byhhh2
Copy link
Contributor

byhhh2 commented Jul 4, 2024

@ttppggnnss 님, @yceffort-naver 님! cna@13, cra@18 기준으로 확인해보았습니다~~

  • eslint-plugin-import의 peer가 exact 버전(2.25.2)만 기록되어 있어서, 만약 사용처에 다른 버전이 설치되어 있다면 eslint-confg가 설치되지 않습니다.
  • @typescript-eslint/parser@typescript-eslint/eslint-plugin는 동일한 major 버전을 가져야 하고, 6.9 버전 이상부터 호환되는 코드가 있어서 peer를 >= 7로 수정하려합니다. 만약 사용처에서 관련 peer dep 오류가 발생한다면 7 버전 이상으로 overrides가 필요할 것 같습니당

@yceffort-naver
Copy link

의존성과 eslint 전문가가 다 되셨군요 (...)
PR 주시면 검토해보겠습니다!!

@byhhh2 byhhh2 linked a pull request Jul 10, 2024 that will close this issue
@byhhh2 byhhh2 reopened this Jul 10, 2024
@byhhh2
Copy link
Contributor

byhhh2 commented Jul 10, 2024

@ttppggnnss 님!

코멘트 내용 @naverpay/eslint-config@1.0.5 버전에 반영되었습니다 :)

@byhhh2 byhhh2 closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants