Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 get #173

Closed
wants to merge 3 commits into from
Closed

🚀 get #173

wants to merge 3 commits into from

Conversation

yceffort-naver
Copy link
Contributor

@yceffort-naver yceffort-naver commented Dec 13, 2024

This resolves #68

image

모든 케이스 커버 불가능 (커버하면 성능이 비슷할듯)

Copy link
Contributor

github-actions bot commented Dec 13, 2024

✅ All utility modules are properly registered

@npayfebot
Copy link
Collaborator

npayfebot commented Dec 13, 2024

✅ Changeset detected

Latest commit: 4fa9d10

@naverpay/hidash package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
get src/get.bench.ts > get performance hidash is 1.97x faster 152.86 🏆 77.63

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/get.bench.ts",
      "groups": [
        {
          "fullName": "src/get.bench.ts > get performance",
          "benchmarks": [
            {
              "id": "196551904_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 3.5086266507330537,
              "samples": [],
              "totalTime": 503.7297049999996,
              "min": 6.179196000000047,
              "max": 12.67994299999998,
              "hz": 152.859756404479,
              "period": 6.541944220779216,
              "mean": 6.541944220779216,
              "variance": 1.0223510476895559,
              "sd": 1.0111137659480045,
              "sem": 0.11522710763371002,
              "df": 76,
              "critical": 1.992,
              "moe": 0.22953239840635037,
              "p75": 6.389388999999937,
              "p99": 12.67994299999998,
              "p995": 12.67994299999998,
              "p999": 12.67994299999998,
              "sampleCount": 77,
              "median": 6.292186999999956
            },
            {
              "id": "196551904_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.4112678172999335,
              "samples": [],
              "totalTime": 502.3901099999997,
              "min": 12.713245000000143,
              "max": 13.551845000000071,
              "hz": 77.62891669981326,
              "period": 12.881797692307686,
              "mean": 12.881797692307686,
              "variance": 0.026688930498009987,
              "sd": 0.1633674707461984,
              "sem": 0.02615973148239533,
              "df": 38,
              "critical": 2.0252,
              "moe": 0.05297868819814702,
              "p75": 12.902800999999954,
              "p99": 13.551845000000071,
              "p995": 13.551845000000071,
              "p999": 13.551845000000071,
              "sampleCount": 39,
              "median": 12.837598000000071
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

@yceffort-naver yceffort-naver marked this pull request as ready for review December 18, 2024 13:02
@yceffort-naver yceffort-naver requested a review from a team as a code owner December 18, 2024 13:02
@yceffort-naver
Copy link
Contributor Author

gg

@yceffort-naver yceffort-naver self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get
2 participants