Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ring conformance tests should not *require* base_ring #1944

Closed
fingolfin opened this issue Dec 21, 2024 · 0 comments · Fixed by #1946
Closed

Ring conformance tests should not *require* base_ring #1944

fingolfin opened this issue Dec 21, 2024 · 0 comments · Fixed by #1946

Comments

@fingolfin
Copy link
Member

Still should test it if available, though, at least test that it is consistent with base_ring_type.

See also discussion at thofma/Hecke.jl#1707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't require base_ring in ring conformance tests Nemocas/AbstractAlgebra.jl
1 participant
@fingolfin