From 82a113c80faaac6fd261415d115cd9ca6680740b Mon Sep 17 00:00:00 2001 From: neoscript Date: Thu, 8 Feb 2024 18:41:04 +0000 Subject: [PATCH 1/4] Fix devcontainer formatting --- .devcontainer/devcontainer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index a940228..b6625bf 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -12,7 +12,7 @@ // "features": {}, // Use 'forwardPorts' to make a list of ports inside the container available locally. - "forwardPorts": [4200, 8681, 7200], + "forwardPorts": [4200, 8681, 7200] // Use 'postCreateCommand' to run commands after the container is created. // "postCreateCommand": "yarn install", From a477e700193ce1d46f2abd04725f4b94ecb51ece Mon Sep 17 00:00:00 2001 From: neoscript Date: Thu, 8 Feb 2024 18:51:48 +0000 Subject: [PATCH 2/4] Upgrade action --- .github/workflows/deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 7eefd39..ec8f623 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -16,7 +16,7 @@ jobs: contents: read steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Build image run: docker build . --tag $IMAGE_NAME --label "runnumber=${GITHUB_RUN_ID}" From 901f0b983e89dbadcf4b76e5023ece186154135e Mon Sep 17 00:00:00 2001 From: neoscript Date: Thu, 8 Feb 2024 18:53:20 +0000 Subject: [PATCH 3/4] include setup node for explicit setup --- .github/workflows/deploy.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index ec8f623..0ce1a79 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -17,6 +17,9 @@ jobs: steps: - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: 20 - name: Build image run: docker build . --tag $IMAGE_NAME --label "runnumber=${GITHUB_RUN_ID}" From 49a5dbbd3aa072eda3f37575856be501fd32be8a Mon Sep 17 00:00:00 2001 From: neoscript Date: Thu, 8 Feb 2024 18:53:55 +0000 Subject: [PATCH 4/4] Update node in dockerfile this is the node version that is used during build --- .github/workflows/deploy.yml | 3 --- Dockerfile | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0ce1a79..ec8f623 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -17,9 +17,6 @@ jobs: steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: 20 - name: Build image run: docker build . --tag $IMAGE_NAME --label "runnumber=${GITHUB_RUN_ID}" diff --git a/Dockerfile b/Dockerfile index 7e03318..b706c91 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:16-alpine as build +FROM node:20-alpine as build WORKDIR /app ADD webapp .