From 683bcf23df40a652ca4fa3dd94e0e73f9442e466 Mon Sep 17 00:00:00 2001
From: Daniel McKnight <daniel@neon.ai>
Date: Tue, 23 Jan 2024 17:46:44 -0800
Subject: [PATCH] Refactor token logic to internal methods to ensure stable API

---
 neon_utils/hana_utils.py | 12 ++++++------
 tests/hana_util_tests.py | 10 +++++-----
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/neon_utils/hana_utils.py b/neon_utils/hana_utils.py
index c3f295c6..e37d9804 100644
--- a/neon_utils/hana_utils.py
+++ b/neon_utils/hana_utils.py
@@ -59,14 +59,14 @@ def _init_client(backend_address: str):
             with open(_client_config_path) as f:
                 _client_config = json.load(f)
         else:
-            get_token(backend_address)
+            _get_token(backend_address)
 
     if not _headers:
         _headers = {"Authorization": f"Bearer {_client_config['access_token']}"}
 
 
-def get_token(backend_address: str, username: str = "guest",
-              password: str = "password"):
+def _get_token(backend_address: str, username: str = "guest",
+               password: str = "password"):
     """
     Get new auth tokens from the specified server. This will cache the returned
     token, overwriting any previous data at the cache path.
@@ -87,7 +87,7 @@ def get_token(backend_address: str, username: str = "guest",
         json.dump(_client_config, f, indent=2)
 
 
-def refresh_token(backend_address: str):
+def _refresh_token(backend_address: str):
     """
     Get new tokens from the specified server using an existing refresh token
     (if it exists). This will update the cached tokens and associated metadata.
@@ -127,10 +127,10 @@ def request_backend(endpoint: str, request_data: dict,
     _init_client(backend_address)
     if time() >= _client_config.get("expiration", 0):
         try:
-            refresh_token(backend_address)
+            _refresh_token(backend_address)
         except ServerException as e:
             LOG.error(e)
-            get_token(backend_address)
+            _get_token(backend_address)
     resp = requests.post(f"{backend_address}/{endpoint.lstrip('/')}",
                          json=request_data, headers=_headers)
     if resp.ok:
diff --git a/tests/hana_util_tests.py b/tests/hana_util_tests.py
index 37d8a029..2fcb51d8 100644
--- a/tests/hana_util_tests.py
+++ b/tests/hana_util_tests.py
@@ -73,10 +73,10 @@ def test_request_backend(self):
         # TODO: Test invalid route, invalid request data
 
     def test_00_get_token(self):
-        from neon_utils.hana_utils import get_token
+        from neon_utils.hana_utils import _get_token
 
         # Test valid request
-        get_token(self.test_server)
+        _get_token(self.test_server)
         from neon_utils.hana_utils import _client_config
         self.assertTrue(isfile(self.test_path))
         with open(self.test_path) as f:
@@ -93,13 +93,13 @@ def _write_token(*_, **__):
                 json.dump(valid_config, c)
             neon_utils.hana_utils._client_config = valid_config
 
-        from neon_utils.hana_utils import refresh_token
+        from neon_utils.hana_utils import _refresh_token
         get_token.side_effect = _write_token
 
         self.assertFalse(isfile(self.test_path))
 
         # Test valid request (auth + refresh)
-        refresh_token(self.test_server)
+        _refresh_token(self.test_server)
         get_token.assert_called_once()
         from neon_utils.hana_utils import _client_config
         self.assertTrue(isfile(self.test_path))
@@ -108,7 +108,7 @@ def _write_token(*_, **__):
         self.assertEqual(credentials_on_disk, _client_config)
 
         # Test refresh of existing token (no auth)
-        refresh_token(self.test_server)
+        _refresh_token(self.test_server)
         get_token.assert_called_once()
         with open(self.test_path) as f:
             new_credentials = json.load(f)