Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No range checks in NativeCurrency #276

Closed
Sword-Smith opened this issue Dec 4, 2024 · 3 comments
Closed

No range checks in NativeCurrency #276

Sword-Smith opened this issue Dec 4, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Sword-Smith
Copy link
Member

There are to loops in NativeCurrency where there are no range checks on the size indicators of dynamically-sized structs. These size indicators are, AFAICT, used to find the next element in a list, and should thus be range-checked.

@Sword-Smith Sword-Smith added the good first issue Good for newcomers label Dec 4, 2024
aszepieniec added a commit that referenced this issue Dec 6, 2024
Closes #276.

Co-authored-by: Thorkil Schmidiger <thor@neptune.cash>
Sword-Smith added a commit that referenced this issue Dec 6, 2024
Closes #276.

Co-authored-by: Thorkil Schmidiger <thor@neptune.cash>
@elielnfinic
Copy link
Contributor

I am willing to work on this.

@aszepieniec
Copy link
Contributor

Hi @elielnfinic! Sorry to inform that this issue has already been fixed by 9368dd7. The reason why this issue is still open is because that commit lives on a branch that has not been merged into master yet, but soon will be.

If you are eager to contribute, here are some high-priority open issues:

@elielnfinic
Copy link
Contributor

Alright, I will pick some tasks. Btw, it would be good to also share these tasks on the Telegram group(maybe??).

dan-da pushed a commit to dan-da/neptune-core that referenced this issue Dec 28, 2024
Closes Neptune-Crypto#276.

Co-authored-by: Thorkil Schmidiger <thor@neptune.cash>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants