Collect aggregate efficiency data for ONTAP 9.8 and below through Harvest Rest Collector

[rahulguptajss]

ONTAP 9.8 and below does not expose efficiency fields through Zapi. There is a way to collect the same through Rest collector. Harvest Rest collector is officially supported from ONTAP 9.12 so sugestion here is just a workaround. Below are the required template changes.

1. Add Rest Collector for such clusters [9.8 or below] in harvest config. (Zapi collector is still required)
2. Comment out all objects listed under rest default.yaml
3. Create a new file custom.yaml here with below contents

objects:
  AggregateEfficiency:         custom_aggr_efficiency.yaml

4: Create a new file custom_aggr_efficiency here with below contents

updated custom_agg_efficiency template as below.

name:               Aggregate
query:              api/storage/aggregates
object:             aggr

counters:
  - ^name                                                          => aggr
  - ^^uuid                                                         => uuid
  - ^home_node.name                                                => node
  - ^state                                                         => state
  - ^block_storage.primary.disk_type                               => type
  - ^block_storage.primary.raid_type                               => raid_type
  - space.efficiency_without_snapshots.logical_used                => logical_used_wo_snapshots
  - space.efficiency_without_snapshots.savings                     => efficiency_savings_wo_snapshots
  - hidden_fields:
      - space


plugins:
  - LabelAgent:
      compute_metric:
        - physical_used_wo_snapshots SUBTRACT space.efficiency_without_snapshots.logical_used space.efficiency_without_snapshots.savings

5: Restart harvest/relevant pollers.

Note: During upgrade, rollback above changes and redo post upgrade.

[rahulguptajss]

updated custom_agg_efficiency template as below and in above post also.

name:               Aggregate
query:              api/storage/aggregates
object:             aggr

counters:
  - ^name                                                          => aggr
  - ^^uuid                                                         => uuid
  - ^home_node.name                                                => node
  - ^state                                                         => state
  - ^block_storage.primary.disk_type                               => type
  - ^block_storage.primary.raid_type                               => raid_type
  - space.efficiency_without_snapshots.logical_used                => logical_used_wo_snapshots
  - space.efficiency_without_snapshots.savings                     => efficiency_savings_wo_snapshots
  - hidden_fields:
      - space


plugins:
  - LabelAgent:
      compute_metric:
        - physical_used_wo_snapshots SUBTRACT space.efficiency_without_snapshots.logical_used space.efficiency_without_snapshots.savings