fix: linting issues (#433)

* [linting] fix iterable issue in get log file action for legacy case

* [linting] services.utils

* [linting] search artifacts action

* ignore whole psycopg2 module while linting as psycopg2.errors ignoring does not work anymore

Author: saikonen

services/ui_backend_service/data/cache/get_log_file_action.py

@@ -399,7 +399,7 @@ def get_log_content(self, task: Task, logtype: str):
             ), ]
         # Note this is inefficient - we will load a 1GB log even if we only want last 100 bytes.
         # Doing this efficiently is a step change in complexity and effort - we can do it when justified in future.
-        raw_content = get_log_content(task, logtype)
+        raw_content = list(get_log_content(task, logtype))
         if len(raw_content) == 0:
             return raw_content  # empty list
 

services/ui_backend_service/data/cache/search_artifacts_action.py

@@ -142,7 +142,7 @@ def format_loc(x):
             if key in results:
                 load_success, value, detail, trace = unpack_processed_value(json.loads(results[key]))
             else:
-                load_success, value, _ = False, None, None
+                load_success, value, detail, trace = False, None, None, None
             # keep the matching case-insensitive
             matches = filter_fn(str(value).lower(), searchterm.lower())
 

services/utils/__init__.py

@@ -272,6 +272,8 @@ def connection_string_url(self, type=None):
             base_url = f'postgresql://{quote(self._user)}:{quote(self._password)}@{self._host}:{self._port}/{self._database_name}'
         elif type == DBType.READER:
             base_url = f'postgresql://{quote(self._user)}:{quote(self._password)}@{self._read_replica_host}:{self._port}/{self._database_name}'
+        else:
+            raise Exception("Unsupported DBType %s" % type)
 
         if (self._ssl_mode in ['allow', 'prefer', 'require', 'verify-ca', 'verify-full']):
             ssl_query = f'sslmode={self._ssl_mode}'

tox.ini

@@ -10,7 +10,7 @@ passenv = MF_METADATA_DB_HOST,MF_METADATA_DB_PORT,MF_METADATA_DB_USER,MF_METADAT
 extras = tests
 
 [testenv:pylint]
-commands = pylint -E services --ignored-modules=psycopg2.errors,pygit2
+commands = pylint -E services --ignored-modules=psycopg2,pygit2
 
 [testenv:unit]
 commands = pytest --cov=services -m unit_tests