Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package installation problems #16

Closed
Angelina-C opened this issue Jun 11, 2024 · 0 comments · Fixed by #17
Closed

Fix package installation problems #16

Angelina-C opened this issue Jun 11, 2024 · 0 comments · Fixed by #17
Labels
bug Something isn't working

Comments

@Angelina-C
Copy link
Collaborator

The package version 1.0.0 from PyPi could not be installed. This was due to the code not being organized in a package. This should be fixed in this issue.

  • Create a python package adb_pywrapper (note the underscore, a dash will not work)
  • move adb-pywrapper.py to this package
  • move the contents of adb_init.py to the package init
  • improve the setup.py to find the package
  • refactor the contents of adb_pywrapper.py so the imports are clean
  • adjust the README to match the correct imports
@Angelina-C Angelina-C added the bug Something isn't working label Jun 11, 2024
@Angelina-C Angelina-C linked a pull request Jun 11, 2024 that will close this issue
Fix package installation problems and refactor classes #17
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix package installation problems and refactor classes NetherlandsForensicInstitute/adb-pywrapper
1 participant
@Angelina-C