Fix flaky tests

Author: rubo

src/Nethermind/Nethermind.JsonRpc.Test/JsonRpcSocketsClientTests.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Net;
@@ -63,7 +64,6 @@ public async Task Can_handle_very_large_objects()
             Assert.That(sent, Is.EqualTo(received));
         }
 
-        [Test]
         [TestCase(1)]
         [TestCase(2)]
         [TestCase(10)]
@@ -80,7 +80,12 @@ static async Task<int> CountNumberOfMessages(Socket socket, CancellationToken to
                     byte[] buffer = new byte[10];
                     while (true)
                     {
-                        ReceiveResult? result = await stream.ReceiveAsync(buffer).ConfigureAwait(false);
+                        ReceiveResult? result = await stream.ReceiveAsync(buffer);
+
+                        // Imitate random delays
+                        if (Stopwatch.GetTimestamp() % 1001 == 0)
+                            await Task.Delay(1);
+
                         if (result is not null && IsEndOfIpcMessage(result))
                         {
                             messages++;
@@ -108,7 +113,7 @@ static async Task<int> CountNumberOfMessages(Socket socket, CancellationToken to
             Task<int> sendMessages = Task.Run(async () =>
             {
                 using Socket socket = new(ipEndPoint.AddressFamily, SocketType.Stream, ProtocolType.Tcp);
-                await socket.ConnectAsync(ipEndPoint).ConfigureAwait(false);
+                await socket.ConnectAsync(ipEndPoint);
 
                 using IpcSocketMessageStream stream = new(socket);
                 using JsonRpcSocketsClient<IpcSocketMessageStream> client = new(
@@ -123,18 +128,18 @@ static async Task<int> CountNumberOfMessages(Socket socket, CancellationToken to
 
                 for (int i = 0; i < messageCount; i++)
                 {
-                    using JsonRpcResult result = JsonRpcResult.Single(RandomSuccessResponse(1_000, () => disposeCount++), default);
-                    await client.SendJsonRpcResult(result).ConfigureAwait(false);
-                    await Task.Delay(1).ConfigureAwait(false);
+                    using JsonRpcResult result = JsonRpcResult.Single(RandomSuccessResponse(1000, () => disposeCount++), default);
+                    await client.SendJsonRpcResult(result);
+                    await Task.Delay(1);
                 }
 
                 disposeCount.Should().Be(messageCount);
-                await cts.CancelAsync().ConfigureAwait(false);
+                await cts.CancelAsync();
 
                 return messageCount;
             });
 
-            await Task.WhenAll(sendMessages, receiveMessages).ConfigureAwait(false);
+            await Task.WhenAll(sendMessages, receiveMessages);
             int sent = sendMessages.Result;
             int received = receiveMessages.Result;
 
@@ -158,7 +163,7 @@ async Task<int> ReadMessages(Socket socket, IList<byte[]> receivedMessages, Canc
                     byte[] buffer = new byte[bufferSize];
                     while (true)
                     {
-                        ReceiveResult? result = await stream.ReceiveAsync(buffer).ConfigureAwait(false);
+                        ReceiveResult? result = await stream.ReceiveAsync(buffer);
                         if (result is not null)
                         {
                             msg.AddRange(buffer.Take(result.Read));
@@ -190,14 +195,14 @@ async Task<int> ReadMessages(Socket socket, IList<byte[]> receivedMessages, Canc
 
             Task<int> receiveMessages = OneShotServer(
                 ipEndPoint,
-                async socket => await ReadMessages(socket, receivedMessages, cts.Token).ConfigureAwait(false)
+                async socket => await ReadMessages(socket, receivedMessages, cts.Token)
             );
 
             Task<int> sendMessages = Task.Run(async () =>
             {
                 int messageCount = 0;
                 using Socket socket = new(ipEndPoint.AddressFamily, SocketType.Stream, ProtocolType.Tcp);
-                await socket.ConnectAsync(ipEndPoint).ConfigureAwait(false);
+                await socket.ConnectAsync(ipEndPoint);
 
                 using IpcSocketMessageStream stream = new(socket);
                 using JsonRpcSocketsClient<IpcSocketMessageStream> client = new(
@@ -216,20 +221,20 @@ async Task<int> ReadMessages(Socket socket, IList<byte[]> receivedMessages, Canc
                     messageCount++;
                     var msg = Enumerable.Range(11, i).Select(x => (byte)x).ToArray();
                     sentMessages.Add(msg);
-                    await stream.WriteAsync(msg.Append((byte)'\n').ToArray()).ConfigureAwait(false);
+                    await stream.WriteAsync(msg.Append((byte)'\n').ToArray());
 
                     if (i % 10 == 0)
                     {
-                        await Task.Delay(1).ConfigureAwait(false);
+                        await Task.Delay(1);
                     }
                 }
                 stream.Close();
-                await cts.CancelAsync().ConfigureAwait(false);
+                await cts.CancelAsync();
 
                 return messageCount;
             });
 
-            await Task.WhenAll(sendMessages, receiveMessages).ConfigureAwait(false);
+            await Task.WhenAll(sendMessages, receiveMessages);
             int sent = sendMessages.Result;
             int received = receiveMessages.Result;