Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Hive Cancun Test Failures #6677

Closed
spencer-tb opened this issue Feb 9, 2024 · 0 comments · Fixed by #6870
Closed

Remaining Hive Cancun Test Failures #6677

spencer-tb opened this issue Feb 9, 2024 · 0 comments · Fixed by #6870
Assignees

Comments

@spencer-tb
Copy link
Contributor

spencer-tb commented Feb 9, 2024

Description

I'm tagging the last 5 failures here for the hive cancun tests.

Specifically from the engine-cancun simulator.

ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root
ForkchoiceUpdatedV2 To Request Shanghai Payload, Non-Null Beacon Root
ForkchoiceUpdatedV2 To Request Cancun Payload, Non-Null Beacon Root
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True

These can all be explained from the execution apis spec update in ethereum/execution-apis#498.

For the first 4 tests:

ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root
ForkchoiceUpdatedV2 To Request Shanghai Payload, Non-Null Beacon Root
ForkchoiceUpdatedV2 To Request Cancun Payload, Non-Null Beacon Root
Invalid PayloadAttributes, Missing BeaconRoot, Syncing=False

We are essentially sending an fcu with invalid payload attributes and hence expect an error reponse of INVALID_PAYLOAD_ATTRIBUTES. Nethermind is returning INVALID_PARAMS. Should be a simple parameter fix.

For the 5th test case where we are syncing:

Invalid PayloadAttributes, Missing BeaconRoot, Syncing=True

We expect no error response, as from the execution apis PR above, if a client is syncing no payload attributes validations should be ran. Currently nethermind returns with INVALID_PARAMS.

Steps to reproduce

Using the latest version of hive run the following command:

./hive --sim ethereum/engine --client nethermind --client-file configs/cancun.yaml --docker.output --sim.limit engine-cancun/"<test_name>"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants