From b79aecfda1c5ba424f18f071c82d6d6d3ee6cb9d Mon Sep 17 00:00:00 2001
From: "Ankur Sinha (Ankur Sinha Gmail)" <sanjay.ankur@gmail.com>
Date: Fri, 14 Jun 2024 17:06:01 +0100
Subject: [PATCH] fix(sbml-import): make TimeDerivative rhs have a `per_time`
 dimension

Otherwise we end up with dimensionally incorrect values:

```
<TimeDerivative variable="time" value="1"/>
```

It'll now be:

```
<TimeDerivative variable="time" value="tscale * 1"/>
```

where `tscale` has dimensions `per_time`.
---
 src/main/java/org/neuroml/importer/sbml/SBMLImporter.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/neuroml/importer/sbml/SBMLImporter.java b/src/main/java/org/neuroml/importer/sbml/SBMLImporter.java
index 3c84cc4..5317e84 100644
--- a/src/main/java/org/neuroml/importer/sbml/SBMLImporter.java
+++ b/src/main/java/org/neuroml/importer/sbml/SBMLImporter.java
@@ -831,7 +831,7 @@ else if (r.isAssignment()) {
             E.info(">>>> StateVariable "+sv);
             dyn.stateVariables.add(sv);
 
-            TimeDerivative td = new TimeDerivative(sv.getName(), "1");
+            TimeDerivative td = new TimeDerivative(sv.getName(), timeScale.getName() + "* 1");
             dyn.timeDerivatives.add(td);
         }