Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /tutorials/W0D2_PythonWorkshop2/student/W0D2_Tutorial1.html #116

Closed
remy-tang opened this issue Jul 9, 2023 · 1 comment · Fixed by #117
Closed

Issue on page /tutorials/W0D2_PythonWorkshop2/student/W0D2_Tutorial1.html #116

remy-tang opened this issue Jul 9, 2023 · 1 comment · Fixed by #117
Labels
Code-improvement Something is not working as expected, but does not prevent the correct execution typos Typos in the text that do not affect the code

Comments

@remy-tang
Copy link

In the Python refresher 2 (W0D2_Tutorial1), in the part 'Coding Exercise 1: Plotting a histogram', the Markdown cell asks to 'Plot an histogram of J=50 bins of N=10000 realizations of V(t) for t=tmax/10 and t=tmax.'

However in the Python code, nbins = 32. And the solution gives a histogram that corresponds to using nbins = 32, not nbins =50.

Two solutions:

  • the Markdown cell should be: 'Plot an histogram of J=32 bins of N=10000 realizations of V(t) for t=tmax/10 and t=tmax.'
    OR
  • The solution should give an histogram that corresponds to nbins = 50.
@spirosChv spirosChv transferred this issue from NeuromatchAcademy/course-content Jul 9, 2023
@spirosChv spirosChv added typos Typos in the text that do not affect the code Code-improvement Something is not working as expected, but does not prevent the correct execution labels Jul 9, 2023
@spirosChv
Copy link
Contributor

@remy-tang good catch. #117 resolves this following the second option and change the code in order to plot hits with 50 bins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-improvement Something is not working as expected, but does not prevent the correct execution typos Typos in the text that do not affect the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants