Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use either viem or ethers v6 #115

Open
rackstar opened this issue Apr 10, 2024 · 1 comment
Open

chore: Use either viem or ethers v6 #115

rackstar opened this issue Apr 10, 2024 · 1 comment

Comments

@rackstar
Copy link
Collaborator

Overview

Current the SDK is using both libraries. We should just pick one.

We should also check what clients use of the 2 as it might make integration with the SDK easier if we use the same lib.

@rackstar rackstar added the chore label Apr 10, 2024
@rackstar rackstar moved this from ⚖ Backlog to TODO in Engineering Tracker 💻 Apr 10, 2024
@roxdanila roxdanila moved this from TODO to Coming Next in Engineering Tracker 💻 Apr 25, 2024
@roxdanila roxdanila moved this from Coming Next to ⚖ Backlog in Engineering Tracker 💻 May 27, 2024
@Gideonnn
Copy link
Contributor

We only use ethers in build scripts and test files, so I made a pr moving it from dependencies to devDependencies. This has no effect on the bundle size, but only on the node_modules folder of consuming projects (it doesnt install ethers anymore).

I tried fetching events with viem but it resulted in an empty array everytime. By reading the docs I could not figure out what was causing this. I left some code examples in the pr, for when we decide to pick this up again. Check out pr #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⚖ Backlog
Development

No branches or pull requests

3 participants