feat: ERC-4337-compatible passkey (P-256) account system #2443
+4,896
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive passkey signing system for the Nibiru EVM, including smart contracts, a TypeScript SDK, and deployment tooling. The changes are well-structured and cover a lot of ground. My review focuses on several areas for improvement:
- Gas Efficiency: The
evm-e2ePasskeyAccountFactorycontract should use the clone pattern for significant gas savings, similar to itsevm-forgecounterpart. - SDK Portability & Performance: The TypeScript SDK can be improved by removing Node.js-specific dependencies for better browser support and by optimizing resource usage in the bundler interaction logic.
- Code Clarity & Robustness: Some of the scripts and SDK code can be made more maintainable and robust with minor refactoring and by adding cleanup logic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
+ Coverage 59.21% 59.26% +0.04%
==========================================
Files 359 360 +1
Lines 24254 24281 +27
==========================================
+ Hits 14362 14389 +27
Misses 8660 8660
Partials 1232 1232
🚀 New features to boost your workflow:
|
matthiasmatt
changed the title
matthiasmatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new passkey-based ERC-4337 account abstraction flow for Nibiru EVM end-to-end tests, including new smart contracts, a TypeScript SDK for passkey operations, and updated documentation and tooling. It adds a minimal ERC-4337 account contract secured by P-256 signatures, a factory for deploying such accounts, and a Hardhat/TypeScript SDK for testing and interacting with the flow. The documentation is expanded to guide users through setup, deployment, and testing. Several dependency and configuration changes ensure compatibility and smooth development.
ERC-4337 Passkey Account Implementation:
PasskeyAccountandPasskeyAccountFactorycontracts implementing a minimal ERC-4337 account abstraction secured by P-256 public keys and signatures, with a factory for deploying minimal-proxy clones. (evm-e2e/contracts/passkey/PasskeyAccount.sol)EntryPointV06tagging the EntryPoint implementation with a version string for bundler compatibility. (evm-e2e/contracts/passkey/EntryPointV06.sol)evm-e2e/contracts/passkey/UserOperation.sol,evm-e2e/contracts/passkey/interfaces/IEntryPoint.sol) [1] [2]Passkey SDK Addition:
passkey-sdkpackage with TypeScript code for passkey-based user operation construction, bundler interaction, and utilities, including scripts for local bundler operation and E2E tests. (evm-e2e/passkey-sdk/package.json,evm-e2e/passkey-sdk/src/bundler.ts,evm-e2e/passkey-sdk/src/index.ts) [1] [2] [3]Documentation and Developer Tooling:
README.mdwith detailed instructions for installing dependencies, deploying the passkey account factory, running a bundler, and executing E2E tests for the passkey ERC-4337 flow. (evm-e2e/README.md) [1] [2]justfile,package.json) and addresses for new contracts (.entrypoint.addr,.passkeyfactory.addr). [1] [2] [3] [4]Build and Dependency Configuration:
evm-e2e/hardhat.config.ts,evm-e2e/hardhat.config.js) [1] [2]@account-abstraction/contracts@0.6.0and reverted@openzeppelin/contractsto4.9.6for compatibility. (evm-e2e/package.json,evm-e2e/package-lock.json) [1] [2] [3] [4] [5]Addresses and Scripts:
evm-e2e/.entrypoint.addr,evm-e2e/.passkeyfactory.addr) [1] [2]evm-e2e/package.json)These changes collectively enable end-to-end testing and development of passkey-secured ERC-4337 accounts on Nibiru EVM, with a modern SDK and streamlined developer experience.