Merge pull request #6 from NighterDevelopment/copilot/fix-d35cb45c-c317-4574-b6a0-29dea4dfdc6f

Fix spawner filter GUI exploit allowing navigation after spawner destruction

Author: ptthanh02

core/src/main/java/github/nighter/smartspawner/SmartSpawner.java

@@ -367,6 +367,10 @@ public SpawnerStorageUI getSpawnerStorageUI() {
         return spawnerStorageUI;
     }
 
+    public SpawnerManager getSpawnerManager() {
+        return spawnerManager;
+    }
+
     public SpawnerRangeChecker getRangeChecker() {
         return rangeChecker;
     }

core/src/main/java/github/nighter/smartspawner/spawner/gui/storage/filter/FilterConfigUI.java

@@ -92,6 +92,13 @@ public void onPlayerQuit(PlayerQuitEvent event) {
      * Opens the filter configuration GUI for a player and spawner
      */
     public void openFilterConfigGUI(Player player, SpawnerData spawner) {
+        // Validate that the spawner still exists before opening the GUI
+        if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
+            // Spawner no longer exists, do not open the GUI
+            player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
+            return;
+        }
+
         // Create a new inventory with title from language manager
         String title = languageManager.getGuiTitle("gui_title_filter_config");
         Inventory filterInventory = Bukkit.createInventory(
@@ -222,6 +229,15 @@ public void onFilterInventoryClick(InventoryClickEvent event) {
         }
 
         SpawnerData spawner = holder.getSpawnerData();
+        
+        // Validate that the spawner still exists before processing any actions
+        if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
+            // Spawner no longer exists, close the inventory
+            player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
+            player.closeInventory();
+            return;
+        }
+        
         int slot = event.getRawSlot();
 
         // Handle divider clicks (return to storage)
@@ -248,6 +264,14 @@ public void onFilterInventoryClick(InventoryClickEvent event) {
      * Returns to the spawner storage UI
      */
     private void returnToStorage(Player player, SpawnerData spawner) {
+        // Validate that the spawner still exists before allowing navigation
+        if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
+            // Spawner no longer exists, close the inventory and prevent navigation
+            player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
+            player.closeInventory();
+            return;
+        }
+
         // Return to storage menu
         player.playSound(player.getLocation(), Sound.UI_BUTTON_CLICK, 0.8f, 1.0f);
         player.closeInventory();