The windows installer cannot be created for versions wit pre-release or build numbers

[NiklasEi]

E.g.

C:\Program Files\dotnet\sdk\7.0.202\NuGet.targets(132,5): error : 'v0.1.0-manual' is not a valid version string. (Parameter 'value') [D:\a\bevy_game_template\bevy_game_template\build\windows\installer\Installer.wixproj]

Build FAILED.

C:\Program Files\dotnet\sdk\7.0.202\NuGet.targets(132,5): error : 'v0.1.0-manual' is not a valid version string. (Parameter 'value') [D:\a\bevy_game_template\bevy_game_template\build\windows\installer\Installer.wixproj]
    0 Warning(s)
    1 Error(s)

Edit: for some reason, this currently also happens with "normal" version strings like v0.1.0. As a workaround, please apply 6fd0f16 to disable the windows installer.

[michalvankodev]

@NiklasEi Do you know how to avoid this issue? I tried to build v0.1.0 and it didn't get released because of this

[NiklasEi]

Yeah, this issue is bigger than I knew when I opened it. For now, I think you will have to remove the windows installer from the workflow.

If the latest release is green, you could use the small diff from 6fd0f16 to turn it off.

[janhohenheim]

I'm still really confused as to why things like "v0.1.0" work in Foxtrot but not here :/

[mikeder]

FWIW, I think its just the v prefix that NuGet is choking on. It appears if you drop that, it will build a 0.1.0-manual tag just fine.

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 89b4e0a..6a35df2 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -3,11 +3,11 @@ name: release-flow
 on:
   push:
     tags:
-      - "v[0-9]+.[0-9]+.[0-9]+*"
+      - "[0-9]+.[0-9]+.[0-9]+*"
   workflow_dispatch:
     inputs:
       version:
-        description: 'Version - in the form of v1.2.3'
+        description: 'Version - in the form of 1.2.3'
         required: true
         type: string