Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size improvement of credential data serialization #50

Open
sosthene-nitrokey opened this issue Jan 31, 2024 · 1 comment
Open

Size improvement of credential data serialization #50

sosthene-nitrokey opened this issue Jan 31, 2024 · 1 comment

Comments

@sosthene-nitrokey
Copy link

I think that in many cases (if not most), in PublicKeyCredentialRpEntity, the id and the name field will be the same. Maybe we can skip serializing the name when it is equal to the `id ?

The same applies to PublicKeyCredentialUserEntity, with name and display_name which are likely the same.

I'll have to check on real-world websites to see what the call credential.create with.

@robin-nitrokey
Copy link
Member

Some data points:

  • GitHub: display name = real name, name = user name
  • Microsoft: display name = real name, name = mail address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants