-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Timeout for Reset under Qubes #519
Comments
The timeout is defined in https://github.com/Nitrokey/admin-app/blob/4dd16c02e93b928e722c6d2d1fd301681d0f02df/src/admin.rs#L17 Is a 5 second increase really enough to make a difference? If we change it, shouldn’t we go for something like 30 seconds directly? |
yes 30 sec should be well then enough |
Previously, we had a timeout of 15 seconds for the user presence check when rebooting to bootloader. This can be too short in some situations, see for example Nitrokey/nitrokey-3-firmware#519. This patch increases the timeout to 30 seconds.
@nestire I might have misunderstood your request because nitrokey-app2 and Qubes is directly linked to bootloader issues in my brain. ^^ You were actually referring to the FIDO2 reset, right? |
Oh, right if it's the FIDO2 timeout can we even change it ? from the specs:
|
Yes, that timeout is fixed. |
@nestire Can you please confirm that this is about the FIDO2 reset? |
This reverts commit 37d5437. I misunderstood the requirement described in Nitrokey/nitrokey-3-firmware#519, so this change was unnecessary.
Backround is that under Qubes it takes much longer to attach a devices to the relevant qube (3 Clicks) and then execute the reset special if you use the nitrokey-app2 this leaves not much margin. A 20 Second Timeout should be enough
The text was updated successfully, but these errors were encountered: