From 7486cb92ba472d85b0761c7a5b5736e3e9ce00c2 Mon Sep 17 00:00:00 2001
From: "Peter H. Hoeg" <peter@hoeg.com>
Date: Wed, 8 Jan 2025 14:42:29 +0100
Subject: [PATCH] kphotoalbum: 5.11.0 -> 6.0.1

---
 .../kp/kphotoalbum/package.nix}               | 49 +++++++------------
 pkgs/top-level/all-packages.nix               |  2 -
 2 files changed, 17 insertions(+), 34 deletions(-)
 rename pkgs/{applications/graphics/kphotoalbum/default.nix => by-name/kp/kphotoalbum/package.nix} (51%)

diff --git a/pkgs/applications/graphics/kphotoalbum/default.nix b/pkgs/by-name/kp/kphotoalbum/package.nix
similarity index 51%
rename from pkgs/applications/graphics/kphotoalbum/default.nix
rename to pkgs/by-name/kp/kphotoalbum/package.nix
index 6af9d69f5574e..41792f04b4755 100644
--- a/pkgs/applications/graphics/kphotoalbum/default.nix
+++ b/pkgs/by-name/kp/kphotoalbum/package.nix
@@ -1,60 +1,45 @@
 {
-  mkDerivation,
-  fetchpatch,
+  stdenv,
   fetchurl,
   lib,
   extra-cmake-modules,
-  kdoctools,
-  wrapGAppsHook3,
   exiv2,
   ffmpeg,
-  libkdcraw,
-  phonon,
   libvlc,
-  kconfig,
-  kiconthemes,
-  kio,
-  kinit,
-  kpurpose,
+  kdePackages,
 }:
 
-mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "kphotoalbum";
-  version = "5.11.0";
+  version = "6.0.1";
 
   src = fetchurl {
-    url = "mirror://kde/stable/${pname}/${version}/${pname}-${version}.tar.xz";
-    hash = "sha256-NWtOIHJXtc8PlltYbbp2YwDf/3QI3MdHNDX7WVQMig4=";
+    url = "mirror://kde/stable/kphotoalbum/${finalAttrs.version}/kphotoalbum-${finalAttrs.version}.tar.xz";
+    hash = "sha256-LLsQ66wKDg77nZUIxjcfzvC3AwLOtojuuDgkJm2dsww=";
   };
 
-  # Fix build against exiv2 0.28.1
-  patches = [
-    (fetchpatch {
-      url = "https://invent.kde.org/graphics/kphotoalbum/-/commit/1ceb1ae37f3f95aa290b0846969af4b26f616760.patch";
-      hash = "sha256-SfBJHyJZcysvemc/F09GPczBjcofxGomgjJ814PSU+c=";
-    })
-  ];
+  env.LANG = "C.UTF-8";
 
-  # not sure if we really need phonon when we have vlc, but on KDE it's bound to
-  # be on the system anyway, so there is no real harm including it
   buildInputs = [
+    kdePackages.qtbase
     exiv2
-    phonon
     libvlc
   ];
 
   nativeBuildInputs = [
     extra-cmake-modules
-    kdoctools
-    wrapGAppsHook3
+    kdePackages.wrapQtAppsHook
   ];
 
-  propagatedBuildInputs = [
+  # not sure if we really need phonon when we have vlc, but on KDE it's bound to
+  # be on the system anyway, so there is no real harm including it
+  propagatedBuildInputs = with kdePackages; [
     kconfig
     kiconthemes
     kio
-    kinit
-    kpurpose
+    kxmlgui
+    phonon
+    purpose
     libkdcraw
   ];
 
@@ -67,6 +52,6 @@ mkDerivation rec {
     homepage = "https://www.kphotoalbum.org/";
     license = licenses.gpl2Plus;
     maintainers = with maintainers; [ peterhoeg ];
-    inherit (kconfig.meta) platforms;
+    inherit (kdePackages.kconfig.meta) platforms;
   };
-}
+})
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 6673f2f0f2dfa..6dc5d8e4d1fda 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -3917,8 +3917,6 @@ with pkgs;
 
   kio-fuse = libsForQt5.callPackage ../tools/filesystems/kio-fuse { };
 
-  kphotoalbum = libsForQt5.callPackage ../applications/graphics/kphotoalbum { };
-
   krename = libsForQt5.callPackage ../applications/misc/krename { };
 
   krunner-pass = libsForQt5.callPackage ../tools/security/krunner-pass { };