Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #348950
This update includes a few code changes that should be quite self explanatory to work with the new version.
I have yet to test the new binary
aw-notify
and the x11 based watchers as well. If anyone could help with that, it'd be great.One big thing I would like to fix is the
aw-qt
finding the bundled tools likeaw-server
or the bundled watchers, when inside of theactivitywatch
symlinkJoin
. Right now it fails to find any of the bundled tools, as it searches for them withos.path.dirname(os.path.realpath(__file__))
, which points to inside ofaw-qt
instead of thesymlinkJoin
. This means that the program only works if it's installed to PATH...Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.