Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activitywatch: 0.12.2 -> 0.13.2 #319121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

huantianad
Copy link
Contributor

@huantianad huantianad commented Jun 11, 2024

Description of changes

Closes #348950

This update includes a few code changes that should be quite self explanatory to work with the new version.

I have yet to test the new binary aw-notify and the x11 based watchers as well. If anyone could help with that, it'd be great.

One big thing I would like to fix is the aw-qt finding the bundled tools like aw-server or the bundled watchers, when inside of the activitywatch symlinkJoin. Right now it fails to find any of the bundled tools, as it searches for them with os.path.dirname(os.path.realpath(__file__)), which points to inside of aw-qt instead of the symlinkJoin. This means that the program only works if it's installed to PATH...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@huantianad huantianad marked this pull request as ready for review October 16, 2024 04:21
@huantianad
Copy link
Contributor Author

Can't actually test rn because of pyqt build failure, I'll figure something out later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: ActivityWatch 0.12.2 → 0.13.2
1 participant