From dc4a97263a39359e2828f8faae7a9c781e0909c2 Mon Sep 17 00:00:00 2001 From: PierreDemailly <39910767+PierreDemailly@users.noreply.github.com> Date: Wed, 23 Aug 2023 21:00:52 +0200 Subject: [PATCH] fix: build error (#230) --- .github/workflows/codeql.yml | 8 ++++---- .github/workflows/nodejs.yml | 6 ++++-- .github/workflows/scorecards.yml | 4 ++-- .github/workflows/vis-network.yml | 4 ++-- package.json | 10 +++++----- public/js/components/package.info.js | 5 ++++- 6 files changed, 21 insertions(+), 16 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 100d4d28..bddf0758 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -41,7 +41,7 @@ jobs: steps: - name: Harden Runner - uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 + uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1 with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs @@ -50,7 +50,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@0ba4244466797eb048eb91a6cd43d5c03ca8bd05 # v2.21.2 + uses: github/codeql-action/init@a09933a12a80f87b87005513f0abb1494c27a716 # v2.21.4 with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. @@ -63,7 +63,7 @@ jobs: # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@0ba4244466797eb048eb91a6cd43d5c03ca8bd05 # v2.21.2 + uses: github/codeql-action/autobuild@a09933a12a80f87b87005513f0abb1494c27a716 # v2.21.4 # ℹī¸ Command-line programs to run using the OS shell. # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun @@ -76,6 +76,6 @@ jobs: # ./location_of_script_within_repo/buildscript.sh - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@0ba4244466797eb048eb91a6cd43d5c03ca8bd05 # v2.21.2 + uses: github/codeql-action/analyze@a09933a12a80f87b87005513f0abb1494c27a716 # v2.21.4 with: category: "/language:${{matrix.language}}" \ No newline at end of file diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 201d66ba..1e9faf12 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -18,17 +18,19 @@ jobs: fail-fast: false steps: - name: Harden Runner - uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 + uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1 with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0 + uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: node-version: ${{ matrix.node-version }} - name: Install dependencies run: npm install + - name: Build + run: npm run build - name: Run tests run: npm run coverage - name: Send coverage report to Codecov diff --git a/.github/workflows/scorecards.yml b/.github/workflows/scorecards.yml index 42f73e82..56ab9ea1 100644 --- a/.github/workflows/scorecards.yml +++ b/.github/workflows/scorecards.yml @@ -32,7 +32,7 @@ jobs: steps: - name: Harden Runner - uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 + uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1 with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs @@ -72,6 +72,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: "Upload to code-scanning" - uses: github/codeql-action/upload-sarif@0ba4244466797eb048eb91a6cd43d5c03ca8bd05 # v2.21.2 + uses: github/codeql-action/upload-sarif@a09933a12a80f87b87005513f0abb1494c27a716 # v2.21.4 with: sarif_file: results.sarif diff --git a/.github/workflows/vis-network.yml b/.github/workflows/vis-network.yml index 609e175b..44de62ca 100644 --- a/.github/workflows/vis-network.yml +++ b/.github/workflows/vis-network.yml @@ -22,13 +22,13 @@ jobs: fail-fast: false steps: - name: Harden Runner - uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 + uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1 with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0 + uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1 with: node-version: ${{ matrix.node-version }} - name: Install dependencies diff --git a/package.json b/package.json index e98b306d..93c008e0 100644 --- a/package.json +++ b/package.json @@ -63,12 +63,12 @@ "@nodesecure/eslint-config": "^1.7.1", "@nodesecure/size-satisfies": "^1.1.0", "@nodesecure/vis-network": "^1.4.0", - "@types/node": "^20.4.5", + "@types/node": "^20.5.3", "c8": "^8.0.1", "cross-env": "^7.0.3", - "esbuild": "^0.18.17", - "eslint": "^8.46.0", - "esmock": "^2.3.5", + "esbuild": "^0.19.2", + "eslint": "^8.47.0", + "esmock": "^2.3.8", "http-server": "^14.1.1", "pkg-ok": "^3.0.0", "pretty-bytes": "^6.1.1", @@ -88,7 +88,7 @@ "@polka/send-type": "^0.5.2", "@topcli/cliui": "^1.1.0", "@topcli/spinner": "^2.1.2", - "cacache": "^17.1.3", + "cacache": "^18.0.0", "dotenv": "^16.3.1", "filenamify": "^6.0.0", "ini": "^4.1.1", diff --git a/public/js/components/package.info.js b/public/js/components/package.info.js index f03d0b4d..aeb5822c 100644 --- a/public/js/components/package.info.js +++ b/public/js/components/package.info.js @@ -656,7 +656,10 @@ export class PackageInfo { async generateOssfScorecard() { if (!this.links.github.href) { - document.getElementById('scorecard-menu')?.style.display = 'none'; + const scorecardMenu = document.getElementById('scorecard-menu'); + if (scorecardMenu) { + scorecardMenu.style.display = 'none'; + } return; }