feat: Use the latest version support by Slang even if not resolved

This is arguably more useful approach - we designed our parser to be
error-tolerant and it makes more sense to offer slightly incomplete
experience rather than just suddenly turning off all features just
because the user is using a slightly newer version that may not get full
coverage.

Author: Xanewok

server/src/parser/slangHelpers.ts

@@ -6,6 +6,7 @@ import { TextDocument } from "vscode-languageserver-textdocument";
 import { Range } from "vscode-languageserver-types";
 import { Language } from "@nomicfoundation/slang/language";
 import semver from "semver";
+import { Logger } from "../utils/Logger";
 import { getPlatform } from "../utils/operatingSystem";
 
 export type SlangNode = RuleNode | TokenNode;
@@ -46,21 +47,27 @@ export function isSlangSupported() {
   return SUPPORTED_PLATFORMS.includes(currentPlatform);
 }
 
-export function getLanguage(versionPragmas: string[]): Language {
-  const supportedVersions = Language.supportedVersions();
+export function resolveVersion(
+  logger: Logger,
+  versionPragmas: string[]
+): string {
+  const versions = Language.supportedVersions();
 
-  const slangVersion = semver.maxSatisfying(
-    supportedVersions,
-    versionPragmas.join(" ")
-  );
+  const slangVersion = semver.maxSatisfying(versions, versionPragmas.join(" "));
 
-  if (slangVersion === null) {
-    const latest = supportedVersions[supportedVersions.length - 1];
-    throw new Error(
-      `No Slang-supported version (latest: ${latest}) for Solidity found that satisfies the pragma directives: '${versionPragmas.join(
-        " "
-      )}'.`
+  if (slangVersion !== null) {
+    return slangVersion;
+  } else {
+    const latest = versions[versions.length - 1];
+
+    logger.error(
+      new Error(
+        `No Slang-supported version (latest: ${latest}) for Solidity found that satisfies the pragma directives: '${versionPragmas.join(
+          " "
+        )}'.`
+      )
     );
+
+    return latest;
   }
-  return new Language(slangVersion);
 }

server/src/services/documentSymbol/onDocumentSymbol.ts

@@ -5,10 +5,11 @@ import { DocumentSymbolParams } from "vscode-languageserver/node";
 import { DocumentSymbol, SymbolInformation } from "vscode-languageserver-types";
 import { analyze } from "@nomicfoundation/solidity-analyzer";
 import _ from "lodash";
+import { Language } from "@nomicfoundation/slang/language";
 import { RuleKind } from "@nomicfoundation/slang/kinds";
 import { RuleNode } from "@nomicfoundation/slang/cst";
 import { ServerState } from "../../types";
-import { getLanguage } from "../../parser/slangHelpers";
+import { resolveVersion } from "../../parser/slangHelpers";
 import { SymbolTreeBuilder } from "./SymbolTreeBuilder";
 import { StructDefinition } from "./visitors/StructDefinition";
 import { StructMember } from "./visitors/StructMember";
@@ -53,8 +54,10 @@ export function onDocumentSymbol(serverState: ServerState) {
       const { versionPragmas } = analyze(text);
       span.finish();
 
+      const resolvedVersion = resolveVersion(logger, versionPragmas);
+
       try {
-        const language = getLanguage(versionPragmas);
+        const language = new Language(resolvedVersion);
 
         // Parse using slang
         span = transaction.startChild({ op: "slang-parsing" });

server/src/services/semanticHighlight/onSemanticTokensFull.ts

@@ -7,10 +7,11 @@ import {
 } from "vscode-languageserver-protocol";
 import _, { Dictionary } from "lodash";
 import { analyze } from "@nomicfoundation/solidity-analyzer";
+import { Language } from "@nomicfoundation/slang/language";
 import { RuleKind, TokenKind } from "@nomicfoundation/slang/kinds";
 import { TokenNode } from "@nomicfoundation/slang/cst";
 import { ServerState } from "../../types";
-import { getLanguage } from "../../parser/slangHelpers";
+import { resolveVersion } from "../../parser/slangHelpers";
 import { CustomTypeHighlighter } from "./highlighters/CustomTypeHighlighter";
 import { SemanticTokensBuilder } from "./SemanticTokensBuilder";
 import { FunctionDefinitionHighlighter } from "./highlighters/FunctionDefinitionHighlighter";
@@ -54,9 +55,10 @@ export function onSemanticTokensFull(serverState: ServerState) {
         const { versionPragmas } = analyze(text);
         span.finish();
 
-        const language = getLanguage(versionPragmas);
+        const resolvedVersion = resolveVersion(logger, versionPragmas);
 
         try {
+          const language = new Language(resolvedVersion);
           // Parse using slang
           span = transaction.startChild({ op: "slang-parsing" });