Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.tsx with new React 18 docs. #353

Closed
esteban-gs opened this issue Jun 26, 2023 · 0 comments
Closed

Update index.tsx with new React 18 docs. #353

esteban-gs opened this issue Jun 26, 2023 · 0 comments
Assignees
Milestone

Comments

@esteban-gs
Copy link
Contributor

esteban-gs commented Jun 26, 2023

We recently upgraded to React 18 and we will follow up with smaller tickets to solve any parts that may have broken.

In index.tsx, we should render the application root as the React 18 migration docs specify:
https://react.dev/blog/2022/03/08/react-18-upgrade-guide#updates-to-client-rendering-apis

I still see it, but I think it's related to a small thing we might have missed when upgrading to React 18. I'll follow up with a ticket.

Originally posted by @esteban-gs in #351 (review)

Acceptance criteria:

  • index.tsx is rendered as specified in docs
  • Verify that it works by opening the sign in modal and seeing no errors after closing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants