Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace image and update copy on /signup-nonprofit #358

Closed
marvinsjsu opened this issue Jul 19, 2023 · 7 comments
Closed

Replace image and update copy on /signup-nonprofit #358

marvinsjsu opened this issue Jul 19, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request Front End good first issue Good for newcomers

Comments

@marvinsjsu
Copy link
Contributor

The image used in /signup-nonprofit does not match what we have in our Figma mocks. This ticket is to replace this image with the correct asset, update the copy to include "ABOUT YOUR ORGANIZATION" text, and adjust the layout so it matches what's provided in Figma.

Current page:

Image

Figma mock:

Image

Figma - https://www.figma.com/file/K7DT5jYcLKRc9epmNrO0N7/UX---Dev-Handoff?type=design&node-id=1-5&mode=design&t=II3OZI8OgzhdP10A-0

@marvinsjsu marvinsjsu added enhancement New feature or request good first issue Good for newcomers Front End labels Jul 19, 2023
@junsuparkswe
Copy link
Contributor

@marvinsjsu Could I get access to the Figma file? I requested access to my email junsupark94@gmail.com

@marvinsjsu
Copy link
Contributor Author

marvinsjsu commented Jul 31, 2023

I've asked the design team for access on their channel #design-ux-ui ... hopefully, they'll be able to do this soon. If not, we can ping @Allyson Wright to help us with this.

@junsuparkswe
Copy link
Contributor

junsuparkswe commented Aug 6, 2023

@EtoKruto /signup has layout but is blank for me. And /signup-nonprofit is completely blank. Would you be able help me with this?

@junsuparkswe junsuparkswe self-assigned this Aug 6, 2023
@junsuparkswe
Copy link
Contributor

@marvinsjsu /signup and /signup-nonprofit are blank on the main branch. I think you're looking at Dennis' branch 288 feature which has the routes /signup-citizen and /signup-nonprofit.

@denniswangcodes I don't think I can proceed on this ticket until you complete your pull request for these signup pages. Could you let me know when that's done?

@marvinsjsu
Copy link
Contributor Author

marvinsjsu commented Aug 6, 2023

@junsupark94, you're right. Sorry for the confusion here, this is my bad. For this ticket, if you're ok with it @denniswangcodes, can we re-assign it to you since you're already working on the signup pages? I think @denniswangcodes tried to bring this up in our sync-up ... Again, so sorry for the confusion guys.

@denniswangcodes
Copy link
Contributor

@marvinsjsu Sounds good, feel free to reassign to me since I'm already working on these signup pages and no problem at all.
@junsupark94 Correct, the signup page should no longer be needed since we implemented the modal logic to be triggered instead. The PR feature branch, once merged, should reflect expected functionality. Appreciate your awareness on this.

@marvinsjsu
Copy link
Contributor Author

thanks @denniswangcodes @junsupark94, this is re-assigned now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants