Skip to content

noresm2_3_develop : add compset NF1850norbc_tropstratchem_aer2014 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2025
Merged

noresm2_3_develop : add compset NF1850norbc_tropstratchem_aer2014 #182

merged 5 commits into from
Jun 4, 2025

Conversation

DirkOlivie
Copy link

@DirkOlivie DirkOlivie commented Nov 28, 2024 •
edited by gold2718
Loading

Summary: add compset NF1850norbc_tropstratchem_aer2014 - allows to estimate the anthropogenic aerosol ERF

Contributors: Dirk Olivié (@DirkOlivie)

Reviewers: Steve Goldhaber (@gold2718) and Øyvind Seland (@oyvindseland)

Purpose of changes: include extra compset NF1850norbc_tropstratchem_aer2014 (issue #181)

Github PR URL: #182

Changes made to build system: None

Changes made to the namelist: there is a new use_cases file for the new compset (1850_cam6_noresm_tropstratchem_aer2014.xml).

Changes to the defaults for the boundary datasets: None. But new specific emission files are available for this new compset. However only emission files for the f19 resolution are available. For the f09 resolution, the model will not run as I have put in 1850_cam6_noresm_tropstratchem_aer2014.xml:

<ext_frc_specifier hgrid="0.9x1.25">
  'SPECIES ->  NOTAVAILABLE'
</ext_frc_specifier>

and

<srf_emis_specifier hgrid="0.9x1.25">
  'SPECIES -> NOTAVAILABLE'
</srf_emis_specifier>

Is this a good solution?

Substantial timing or memory changes: None

Detailed description of changes

Issues addressed by this PR:
#181 (noresm2_3_develop : NF1850norbc_tropstratchem_aer2014 compset)

@DirkOlivie DirkOlivie added the enhancement New feature or request label Nov 28, 2024
@DirkOlivie DirkOlivie added this to the NorESM2.3 milestone Nov 28, 2024
@DirkOlivie DirkOlivie linked an issue Nov 28, 2024 that may be closed by this pull request
noresm2_3_develop : NF1850norbc_tropstratchem_aer2014 compset #181
Closed
@oyvindseland
Copy link

I imagine there are better methods to inform that a compset does not work for a given resolution?
@gold2718

gold2718
gold2718 requested changes Dec 4, 2024
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current handling of missing emission files happens at run time. I think it should happen as early as possible. See DirkOlivie#2.

@DirkOlivie
Merge pull request #2 from gold2718/PR_aer2014fullchem
f2164dd 
Change how missing emission files are handled
@DirkOlivie
Copy link
Author

Hi Steve, I have now accepted your PR related to better handling of missing emissions files. Can you review this "updated" PR? Best regards, Dirk

@DirkOlivie DirkOlivie requested a review from gold2718 May 2, 2025 09:52
gold2718
gold2718 requested changes May 5, 2025
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few change requests. Please let me know if you think any of them are unwarranted.

cime_config/config_compsets.xml
Comment on lines +246 to +248
<compset>
<alias>NF1850norbc_tropstratchem_aer2014</alias>
<lname>1850_CAM60%NORESM%NORBC%TROPSTRATCHEM%AER2014_CLM50%BGC-CROP_CICE%PRES_DOCN%DOM_MOSART_SGLC_SWAV</lname>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a short test for this configuration would be useful. I suggest an ERP test.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steve, yes, probably a goo idea.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steve @gold2718
how should I implement such a test?
Best regards,
Dirk

@DirkOlivie DirkOlivie requested a review from gold2718 May 6, 2025 17:57
@gold2718
Copy link

gold2718 commented May 8, 2025

I imagine there are better methods to inform that a compset does not work for a given resolution? @gold2718

Should we put a warning or error into build-namelist?

@DirkOlivie
Copy link
Author

Hi Steve @gold2718
concerning the issue with missing emission files and failing build-namelist : is that possibly already addressed in the PR 2, which I accepted?
Best regards, Dirk

@gold2718
Copy link

Hi Steve @gold2718 concerning the issue with missing emission files and failing build-namelist : is that possibly already addressed in the PR 2, which I accepted? Best regards, Dirk

We need to test this to make sure the error message appears. Also, the error message could be made more specific (or just provide some hints as to what the problem might be).

@gold2718
Copy link

@DirkOlivie, the ERP_Ln9.f09_f09_mtn14.NFHISTnorpddmsbc.betzy_intel.cam-outfrq9s test has quite a different namelist than the last baseline. Is that expected?

@DirkOlivie
Copy link
Author

Hi Steve @gold2718 ,
what are the differences : is it in emission files? Or something else?

@gold2718
Copy link

Hi Steve @gold2718 , what are the differences : is it in emission files? Or something else?

It is quite a lot. See:
diff /cluster/work/users/goldy/camtest/test_aux_cam_noresm_2025_05_25/ERP_Ln9.f09_f09_mtn14.NFHISTnorpddmsbc.betzy_intel.cam-outfrq9s.C.aer2014_fullchem/CaseDocs/atm_in /cluster/shared/noresm/noresm_baselines/cam_develop/noresm2_3_alpha03/ERP_D_Ln9.f19_f19_mtn14.NF1850norbc_tropstratchem.betzy_intel.cam-outfrq9s/CaseDocs/atm_in

@DirkOlivie
Copy link
Author

Hi Steve @gold2718
concerning the difference between the two atm_in files:

  • ERP_Ln9.f09_f09_mtn14.NFHISTnorpddmsbc.betzy_intel.cam-outfrq9s.C.aer2014_fullchem : based on the atm_in, this seems not to be a full-chemistry, but just an aerosol-only simulation. Is this test done/setup with the correct compset?
  • ERP_D_Ln9.f19_f19_mtn14.NF1850norbc_tropstratchem.betzy_intel.cam-outfrq9s : seems to be indeed a full-chemistry compset.

The tests seem to further differ in their horizontal resolution:

  • ERP_Ln9.f09_f09_mtn14.NFHISTnorpddmsbc.betzy_intel.cam-outfrq9s.C.aer2014_fullchem : 1x1
  • ERP_D_Ln9.f19_f19_mtn14.NF1850norbc_tropstratchem.betzy_intel.cam-outfrq9s : 2x2

Does this help? Does it make sense?

@gold2718
Copy link

gold2718 commented Jun 4, 2025

@DirkOlivie, I'm sorry, that difference compared the wrong two tests. Looking at the tropstrat test from the previous baseline, it is only a diagnostic output change.

gold2718
gold2718 approved these changes Jun 4, 2025
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, thanks!

@gold2718 gold2718 merged commit 71ce215 into NorESMhub:noresm2_3_develop Jun 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in NorESM Development Jun 4, 2025
@gold2718 gold2718 removed the request for review from oyvindseland June 4, 2025 21:17
@gold2718 gold2718 self-assigned this Jun 4, 2025
@gold2718
Copy link

gold2718 commented Jun 4, 2025

Tagged as cam_noresm2_3_v1.0.0f. Sorry for all the delays.

@gold2718 gold2718 mentioned this pull request Jul 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 approved these changes

Assignees

@gold2718 gold2718

Labels
enhancement New feature or request
Projects
NorESM Development
Status: Done
Milestone
NorESM2.3
Development

Successfully merging this pull request may close these issues.

noresm2_3_develop : NF1850norbc_tropstratchem_aer2014 compset
3 participants
@DirkOlivie @oyvindseland @gold2718