Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable OpenJDK install #28

Open
Phaestion opened this issue Sep 11, 2024 · 1 comment
Open

Option to disable OpenJDK install #28

Phaestion opened this issue Sep 11, 2024 · 1 comment

Comments

@Phaestion
Copy link

We typically do Compose Multiplatform development and target both Android and Desktop, and sometimes only desktop.
Therefore many times we would already have Java installed in out Dev Container setup via the "Dev Containers Spec Maintainers" feature (https://github.com/devcontainers/features/tree/main/src/java)

It would be great to disable the installation of OpenJDK, I guess the best way would be to do this via an optional setting in the Options of this feature. With the default set so that OpenJDK is installed unless the option is set from the default.

I'm happy to provide a PR to do this too.

@Phaestion Phaestion changed the title Disable OpenJDK install Option to disable OpenJDK install Sep 11, 2024
@filiphsps
Copy link
Member

filiphsps commented Sep 17, 2024

Hi!

I'm happy to provide a PR to do this too.

PRs are more than welcome 🤠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants