Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slices and echoes selection #46

Closed
Laura2305 opened this issue Jan 31, 2024 · 8 comments
Closed

Slices and echoes selection #46

Laura2305 opened this issue Jan 31, 2024 · 8 comments

Comments

@Laura2305
Copy link
Contributor

Laura2305 commented Jan 31, 2024

To be fixed in the package and user examples:

  • Echos selection --> error when running some of the AdjustData.jl functions with echo = nothing
  • Slices selection problem --> error in the user example and main.jl file when selecting slices
  • Slices selection problem --> error in the unwrap function when only two slices are selected
@Laura2305 Laura2305 mentioned this issue Feb 28, 2024
@alexjaffray
Copy link
Collaborator

alexjaffray commented Feb 29, 2024

@Laura2305 looks like a good list of things to fix, let me know when the other PRs (#48 and #49) are ready for review

@Laura2305
Copy link
Contributor Author

@alexjaffray PRs #48 and #49 are ready for review.

@Laura2305
Copy link
Contributor Author

@alexjaffray It would be great if you could review these PRs and the PR in the User_Example folder before ISMRM, as someone may want to download the package after the conference.

@alexjaffray
Copy link
Collaborator

@Laura2305 I'll review today

@alexjaffray
Copy link
Collaborator

@Laura2305 Finalized my review, only a few things need addressing before approval

@Laura2305
Copy link
Contributor Author

@alexjaffray Thanks! I've completed the changes you requested. We should consider making a new release, as the current released version is quite outdated and contains multiple bugs that have been resolved.

@alexjaffray
Copy link
Collaborator

@Laura2305 I've approved, feel free to merge

@Laura2305
Copy link
Contributor Author

@alexjaffray thanks! I've merged and made a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants