Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml dependencies #54

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Update Project.toml dependencies #54

wants to merge 19 commits into from

Conversation

Laura2305
Copy link
Contributor

No description provided.

@Laura2305
Copy link
Contributor Author

Laura2305 commented Sep 26, 2024

MRIReco 0.8 gives an error as the new regularization syntax was not implemented yet.
The images are mirrored in the frequency encoding direction when using MRIReco 0.9 compared to 0.7. But the pipeline works. Is this a minor or major version change when released?

@Laura2305
Copy link
Contributor Author

I've suspended CompatHelper for now.

@Laura2305
Copy link
Contributor Author

Final version of updated dependencies at current date.

@alexjaffray
Copy link
Collaborator

alexjaffray commented Sep 27, 2024

@Laura2305 Looks good to me, thanks for navigating the recent changes in MRIReco.jl.

MRIReco 0.8 gives an error as the new regularization syntax was not implemented yet. The images are mirrored in the frequency encoding direction when using MRIReco 0.9 compared to 0.7. But the pipeline works. Is this a minor or major version change when released?

I would say we should increment to 0.2.0 on release, since if anyone goes to develop (or has modified) the package with their own adjustments, they will have to make additional modifications to adhere to the newer API of MRIReco.jl.

@Laura2305
Copy link
Contributor Author

@alexjaffray ok great! I think we should wait to merge this PR until Julia 1.11 is released, as Julia 1.9 now is quite a stringent requirement and the current released version of the package works. Once this is merged we can make a new release of the package.

@alexjaffray
Copy link
Collaborator

I think so, that would make sense to me. Let's wait to merge once 1.11 releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants