Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Are the concepts of windowCapacity and memoryAlignment applicable to file-downloading or are they only applicable to file-uploading #188

Open
ksidirop-laerdal opened this issue Oct 1, 2024 · 1 comment
Labels
question Further information is requested

Comments

@ksidirop-laerdal
Copy link
Contributor

ksidirop-laerdal commented Oct 1, 2024

I noticed that there's an asymmetry between the way we initiate a file-uploading vs file-downloading. To illustrate my point:

  • In file-uploading we have:
_uploadController = new FileUploader(
   fileSystemManager,
   remoteFilePath,
   data,
   windowCapacity,     <-----
   memoryAlignment   <-----
).uploadAsync(_fileUploaderCallbackProxy);
  • In file-downloading we have:
_downloadingController = _fileSystemManager.fileDownload(remoteFilePath, new FileDownloaderCallbackProxy());

I can't see any way to specify the window-capacity or the memory-alignment parameters on the file-downloading operation.

Am I missing something obvious or is this to be expected because these two notions don't apply to file-downloads?

Appreciate any insights.

@philips77
Copy link
Member

The memoryAlignment parameter is indeed valid only for the transmitter (so only when uploading, or on the device side when downloading to a phone), but we could think of this window capacity. I don't even know it that's supported by the firmware in the current SDKs... I think it should be, never tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants