Bug in RtcGetCalendarTime?

[cdoolin]

I believe there is a bug in RtcGetCalendarTime (in rtc-board.c):

In Lines 198 and 199:

    uint32_t ticks_remainder = value & CLOCK_MS_MASK;
    *milliseconds            = (ticks_remainder >> CLOCK_SHIFT) * 1000;

performing the bit-shift before multiplication will zero the millisecond value, so milliseconds will always be zero. I believe

 *milliseconds            = (ticks_remainder * 1000)  >> CLOCK_SHIFT;

is the correct order of operations, and because of the CLOCK_MS_MASK, should not overflow a uint32_t.

Cheers,

Callum