Fix: Browser Freezes When Using P2P with Shaka Player on Long Live Streams (#454)

* ci: update Node.js and pnpm setup to use LTS versions in workflows

* ci: remove redundant step from PR workflow

* build: update deps to latest versions

* ci: update Node.js setup to use LTS version and pnpm to latest

* ci: remove working-directory  in PR check workflow

* style: remove extra blank space

* fix: browser freezes when using shaka on long live streams

* refactor: segment index handling with eviction count

* Revert "refactor: segment index handling with eviction count"

This reverts commit 7d42b14.

* Revert "fix: browser freezes when using shaka on long live streams"

This reverts commit 02af012.

* refactor: enhance segment reference retrieval in manifest parser

* Update comments

---------

Co-authored-by: Andriy Lysnevych <andriy.lysnevych@novage.com.ua>

Author: DimaDemchenko

packages/p2p-media-loader-shaka/src/manifest-parser-decorator.ts

@@ -14,7 +14,7 @@ export class ManifestParserDecorator implements shaka.extern.ManifestParser {
   private player?: shaka.Player;
 
   constructor(
-    shaka: Readonly<Shaka>,
+    private readonly shaka: Readonly<Shaka>,
     private readonly originalManifestParser: shaka.extern.ManifestParser,
   ) {
     this.isHls = this.originalManifestParser instanceof shaka.hls.HlsParser;
@@ -136,7 +136,14 @@ export class ManifestParserDecorator implements shaka.extern.ManifestParser {
 
         segmentIndex.get = originalGet;
         try {
-          const references = [...segmentIndex];
+          const references = getReferencesArray(
+            segmentIndex as unknown as Record<string, unknown>,
+            this.shaka,
+          );
+          if (!references) {
+            throw new Error("Segment references not found");
+          }
+
           const firstItemReference = references[0];
           const lastItemReference = references[references.length - 1];
 
@@ -154,10 +161,9 @@ export class ManifestParserDecorator implements shaka.extern.ManifestParser {
           stream.isSegmentIndexAlreadyRead = true;
           this.debug(`Stream ${stream.id} is updated`);
         } catch {
-          // This catch is intentionally left blank.
-          // [...segmentIndex] throws an error when segmentIndex inner array is empty
+          // Ignore an error when segmentIndex inner array is empty
         } finally {
-          // do not set custom get again is segment index is already read and stream is VOD
+          // Do not set custom get again if the segment index is already read and the stream is VOD
           if (
             !stream.isSegmentIndexAlreadyRead ||
             !!this.player?.isLive() ||
@@ -262,6 +268,28 @@ export class DashManifestParser extends ManifestParserDecorator {
   }
 }
 
+function getReferencesArray(
+  obj: Record<string, unknown>,
+  shaka: Shaka,
+): shaka.media.SegmentReference[] | null {
+  for (const key in obj) {
+    if (
+      Array.isArray(obj[key]) &&
+      obj[key].length > 0 &&
+      obj[key][0] instanceof shaka.media.SegmentReference
+    ) {
+      return obj[key] as shaka.media.SegmentReference[];
+    } else if (typeof obj[key] === "object") {
+      const references = getReferencesArray(
+        obj[key] as Record<string, unknown>,
+        shaka,
+      );
+      if (references) return references;
+    }
+  }
+  return null;
+}
+
 function getMapPropertiesFromObject(object: Record<string, unknown>) {
   return Object.values(object).filter(
     (property): property is Map<unknown, unknown> => property instanceof Map,