Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlx from 0.6 to 0.7 #37

Closed
pymongo opened this issue Nov 3, 2023 · 1 comment · Fixed by #40
Closed

Upgrade sqlx from 0.6 to 0.7 #37

pymongo opened this issue Nov 3, 2023 · 1 comment · Fixed by #40

Comments

@pymongo
Copy link

pymongo commented Nov 3, 2023

I am trying to update sqlx to 0.7, but Insert trait let mut tx = db.begin().await?; db: impl Executor has no begin method on sqlx 0.7

         db: &mut <Db as Database>::Connection,
         row: impl Insert<Table = Self>,
     ) -> BoxFuture<Result<Self>> {
-        row.insert(db)
+        row.insert(&mut *db)
     }

     /// Insert a row into the database, returning the inserted row.
-    fn insert<'a, 'c: 'a>(
+    fn insert(
         self,
-        db: impl Executor<'c, Database = Db> + 'a,
-    ) -> BoxFuture<'a, Result<Self::Table>>;
+        db: &mut impl sqlx::Connection<Database = Db, Options=sqlx::mysql::MySqlConnectOptions>,
+    ) -> BoxFuture<Result<Self::Table>>;
 }
@NyxCode
Copy link
Owner

NyxCode commented Sep 8, 2024

Working on it, finally. (#40)

@NyxCode NyxCode linked a pull request Sep 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants