Contributing

Reporting Issues

If possible, always attach a pull request when creating an issue (GitHub will automatically create an issue when submitting the changes). The issues not linked to a pull request or an internal request on odoo.com will be handled with a lower priority.

If later on you create a pull request solving an opened issue, do not forget to reference to it in your pull request (e.g.: "This patch fixes issue #42").

When reporting an issue or creating a pull request, use the following structure:

Quantity field is ignored in a sale order

Impacted versions:

• 7.0 and above

Steps to reproduce:

1. create a new sale order
2. add a line with product 'Service', quantity 2, unit price 10.0
3. validate the sale order

Current behavior:

• Total price of 10.0

Expected behavior:

• Total price of 20.0 (2 * 10 = 20)

For web or rendering issues, do not forget to specify the operating system and browser you are using.

Against which version should I submit a patch?

Fixes made in supported versions (so v7.0, saas-3, 4 and 5) will be forward ported up to master periodically. No need to create a pull request for master if we merge a fix in 7.0.

• odoo/master for:
  • changes in the API (method signature or return format)
  • changes requiring an update of the database (e.g. new fields)
  • new features However your change must be submitted against if
• odoo/7.0 (or saas versions 3 to 5 if not applying to 7.0)
  • correction of bugs neither changing the API nor database structure

Why was my issue closed without merging?

A pull request is closed when it will not be merged into odoo. This will typically happens if the fix/issue:

• is not relevant to odoo development (label invalid)
• is not considered as a bug or we have no plan to change the current behavior (label wontfix)
• is a duplicate of another opened issue (label duplicate)
• the pull request should be resubmitted against another version

What is this odoo-dev repository? Should I use it?

The odoo-dev/odoo repository is an internal repository used by the R&D of Odoo to keep the main repository clean. If you are coming from Launchpad, this is the equivalent of the ~openerp-dev repository.

When forking odoo to submit a patch, always use the github.com/odoo/odoo repository. Be also careful of the version you are branching as it will determine the history once the pull request will be realized (e.g.: git checkout -b 7.0-my-branch odoo/7.0).

Meaning of labels

• blocked: a fix or information from the author of the request is required before merging
• confirmed: issue was validated by qualification team
• need review: a second level of review is required
• wishlist: new feature, to discuss if will be integrated
• RDWIP: Internal pull request, work in progress (by odoo SA RD team)
• OE: pull request created to solve an odoo enterprise ticket