From f607e239730e86b63332d1b4180a8ffed6f87fad Mon Sep 17 00:00:00 2001
From: FernandoRomera <fromera@astrohotel.es>
Date: Tue, 6 Aug 2024 10:37:50 +0200
Subject: [PATCH] [MIG] edi_voxel_account_invoice_oca: Migration to 17.0

---
 edi_voxel_account_invoice_oca/__manifest__.py |  2 +-
 .../migrations/15.0.1.0.0/pre-migration.py    | 34 -----------------
 .../tests/test_voxel_account_invoice.py       |  4 +-
 .../views/account_move_views.xml              | 37 +++++++------------
 .../views/res_config_settings_views.xml       |  6 +--
 5 files changed, 17 insertions(+), 66 deletions(-)
 delete mode 100644 edi_voxel_account_invoice_oca/migrations/15.0.1.0.0/pre-migration.py

diff --git a/edi_voxel_account_invoice_oca/__manifest__.py b/edi_voxel_account_invoice_oca/__manifest__.py
index a598c98164..9df26bcab5 100644
--- a/edi_voxel_account_invoice_oca/__manifest__.py
+++ b/edi_voxel_account_invoice_oca/__manifest__.py
@@ -4,7 +4,7 @@
 {
     "name": "Voxel account invoice oca",
     "summary": "Sends account invoices to Voxel.",
-    "version": "15.0.1.0.2",
+    "version": "17.0.1.0.0",
     "development_status": "Production/Stable",
     "category": "Accounting & Finance",
     "author": "Tecnativa, Odoo Community Association (OCA)",
diff --git a/edi_voxel_account_invoice_oca/migrations/15.0.1.0.0/pre-migration.py b/edi_voxel_account_invoice_oca/migrations/15.0.1.0.0/pre-migration.py
deleted file mode 100644
index 5711f330f7..0000000000
--- a/edi_voxel_account_invoice_oca/migrations/15.0.1.0.0/pre-migration.py
+++ /dev/null
@@ -1,34 +0,0 @@
-# Copyright 2023 Tecnativa - Ernesto Tejeda
-# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-
-from openupgradelib import openupgrade
-
-
-@openupgrade.migrate()
-def migrate(env, version):
-    mapping_function_record_data = {
-        (
-            "_get_and_send_voxel_report",
-            env.ref("edi_voxel_oca.channel_voxel_export").id,
-        ): "job_function_get_and_send_voxel_report",
-        (
-            "_update_error_status",
-            env.ref("edi_voxel_oca.channel_voxel_status").id,
-        ): "job_function_update_error_status",
-    }
-    vals_list = []
-    domain = [("model_id", "=", env.ref("account.model_account_move").id)]
-    function = env["queue.job.function"].search(domain)
-    for record in function:
-        key = (record.method, record.channel_id.id)
-        if key in mapping_function_record_data:
-            vals_list.append(
-                {
-                    "noupdate": True,
-                    "name": mapping_function_record_data[key],
-                    "module": "edi_voxel_account_invoice_oca",
-                    "model": "queue.job.function",
-                    "res_id": record.id,
-                }
-            )
-    env["ir.model.data"].create(vals_list)
diff --git a/edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py b/edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py
index 7b2dd01c0e..bb287cbce1 100644
--- a/edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py
+++ b/edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py
@@ -9,7 +9,7 @@
 class TestVoxelAccountInvoice(TransactionCase):
     @classmethod
     def setUpClass(cls):
-        super(TestVoxelAccountInvoice, cls).setUpClass()
+        super().setUpClass()
         cls.env = cls.env(
             context=dict(
                 cls.env.context,
@@ -62,7 +62,7 @@ def setUpClass(cls):
         )
         cls.env["product.customerinfo"].create(
             {
-                "name": partner.id,
+                "partner_id": partner.id,
                 "product_tmpl_id": product_1.product_tmpl_id.id,
                 "product_id": product_1.id,
                 "product_code": "1234567891234",
diff --git a/edi_voxel_account_invoice_oca/views/account_move_views.xml b/edi_voxel_account_invoice_oca/views/account_move_views.xml
index 924d7f22b9..e4374441c3 100644
--- a/edi_voxel_account_invoice_oca/views/account_move_views.xml
+++ b/edi_voxel_account_invoice_oca/views/account_move_views.xml
@@ -4,28 +4,21 @@
         <field name="name">account.move.form.inherit</field>
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_move_form" />
-        <field
-            name="groups_id"
-            eval="[(4, ref('edi_voxel_oca.group_voxel_manager'))]"
-        />
         <field name="arch" type="xml">
             <header position="inside">
                 <button
                     name="action_send_to_voxel"
                     type="object"
                     string="Send to Voxel"
-                    attrs="{'invisible': [
-                            '|',
-                            ('move_type', 'not in', ['out_invoice', 'out_refund']),
-                            ('state', '!=', 'posted'),
-                        ]}"
+                    invisible="move_type not in ['out_invoice', 'out_refund'] or state != 'posted'"
                 />
             </header>
             <notebook position="inside">
                 <field name="voxel_enabled" invisible="1" />
                 <page
                     string="Voxel"
-                    attrs="{'invisible': [('voxel_enabled', '!=', True)]}"
+                    invisible="not voxel_enabled"
+                    groups="edi_voxel_oca.group_voxel_manager"
                 >
                     <group>
                         <field name="voxel_state" />
@@ -33,7 +26,7 @@
                     <group
                         name="group_voxel_processing_error"
                         colspan="8"
-                        attrs="{'invisible': [('processing_error', '=', False)]}"
+                        invisible="not processing_error"
                     >
                         <field name="processing_error" />
                     </group>
@@ -56,7 +49,7 @@
                                             name="voxel_requeue_sudo"
                                             string="Requeue"
                                             class="oe_highlight"
-                                            attrs="{'invisible': [('state', '!=', 'failed')]}"
+                                            invisible="state != 'failed'"
                                         />
                                         <button
                                             type="object"
@@ -64,7 +57,7 @@
                                             string="Cancel sending"
                                             class="oe_highlight_cancel"
                                             icon="fa-times-circle"
-                                            attrs="{'invisible': [('state', 'not in', ['pending','enqueued'])]}"
+                                            invisible="state not in ['pending','enqueued']"
                                         />
                                         <button
                                             type="object"
@@ -72,7 +65,7 @@
                                             string="Send now"
                                             class="oe_highlight"
                                             icon="fa-fighter-jet"
-                                            attrs="{'invisible': ['|', ('state', '!=', 'pending'), ('eta', '=', False)]}"
+                                            invisible="state != 'pending' or (not eta)"
                                         />
                                     </tree>
                                 </field>
@@ -81,13 +74,10 @@
                         <page
                             string="Voxel XML report"
                             name="page_voxel_report"
-                            attrs="{'invisible': [('voxel_xml_report', '=', False)]}"
+                            invisible="not voxel_xml_report"
                         >
                             <group name="group_voxel_report">
-                                <group
-                                    colspan="8"
-                                    attrs="{'invisible': [('voxel_filename', '=', False)]}"
-                                >
+                                <group colspan="8" invisible="not voxel_filename">
                                     <field name="voxel_filename" />
                                 </group>
                                 <group colspan="8">
@@ -109,13 +99,12 @@
         <field name="name">account.invoice.select.inherit</field>
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_account_invoice_filter" />
-        <field
-            name="groups_id"
-            eval="[(4, ref('edi_voxel_oca.group_voxel_manager'))]"
-        />
         <field name="arch" type="xml">
             <filter name="late" position="before">
-                <group string="Voxel filters">
+                <group
+                    string="Voxel filters"
+                    groups="edi_voxel_oca.group_voxel_manager"
+                >
                     <separator />
                     <filter
                         name="voxel_not_sent"
diff --git a/edi_voxel_account_invoice_oca/views/res_config_settings_views.xml b/edi_voxel_account_invoice_oca/views/res_config_settings_views.xml
index 20265846cc..c341d2a0c3 100644
--- a/edi_voxel_account_invoice_oca/views/res_config_settings_views.xml
+++ b/edi_voxel_account_invoice_oca/views/res_config_settings_views.xml
@@ -6,13 +6,9 @@
         <field name="name">res.config.settings.view.form.voxel.invoice</field>
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="edi_voxel_oca.res_config_settings_view_form" />
-        <field
-            name="groups_id"
-            eval="[(4, ref('edi_voxel_oca.group_voxel_manager'))]"
-        />
         <field name="arch" type="xml">
             <xpath expr="//div[@name='voxel_login_config']" position="inside">
-                <div class="row mt16">
+                <div class="row mt16" groups="edi_voxel_oca.group_voxel_manager">
                     <label
                         for="voxel_invoice_login_id"
                         class="col-lg-3 o_light_label"