From c4bcd77a8581374a984aa1b39dac7a4686f7ad3b Mon Sep 17 00:00:00 2001
From: Nils Coenen <nico-solutions@users.noreply.github.com>
Date: Sun, 13 Aug 2023 13:52:45 +0200
Subject: [PATCH] [IMP] improved views concerning categories & tags

- added string "Partner-Tag" if the category refers to Partner-tags instead of worker category (fsm.category)
- added groups-access to tag-ids used in views, to only show tags if "manage tags" (fsm.tags) is enabled
- added groups-access to category_ids used in views, to only show category if "manage categories" (fsm.category) is enabled
---
 fieldservice/readme/CONTRIBUTORS.rst |  1 +
 fieldservice/views/fsm_location.xml  |  4 +++-
 fieldservice/views/fsm_order.xml     | 17 +++++++++++------
 fieldservice/views/fsm_person.xml    |  4 +++-
 fieldservice/views/fsm_template.xml  |  8 ++++++++
 5 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/fieldservice/readme/CONTRIBUTORS.rst b/fieldservice/readme/CONTRIBUTORS.rst
index 72de854016..c6d19acc8a 100644
--- a/fieldservice/readme/CONTRIBUTORS.rst
+++ b/fieldservice/readme/CONTRIBUTORS.rst
@@ -14,3 +14,4 @@
 * `Tecnativa <https://www.tecnativa.com>`_:
 
   * Víctor Martínez
+* Nils Coenen <nils.coenen@nico-solutions.de>
diff --git a/fieldservice/views/fsm_location.xml b/fieldservice/views/fsm_location.xml
index 29bc40ba68..802d5a913d 100644
--- a/fieldservice/views/fsm_location.xml
+++ b/fieldservice/views/fsm_location.xml
@@ -9,6 +9,7 @@
                 <field name="complete_name" />
                 <field
                     name="category_id"
+                    string="Partner-Tags"
                     widget="many2many_tags"
                     options="{'color_field': 'color'}"
                 />
@@ -154,6 +155,7 @@
                             <field
                                 name="category_id"
                                 widget="many2many_tags"
+                                string="Partner-Tags"
                                 options="{'color_field': 'color'}"
                             />
                         </group>
@@ -299,7 +301,7 @@
                 <field name="country_id" />
                 <field name="description" />
                 <field name="tz" />
-                <field name="category_id" />
+                <field name="category_id" string="Partner-Tags" />
                 <field name="ref" />
                 <group expand="0" string="Group By">
                     <filter
diff --git a/fieldservice/views/fsm_order.xml b/fieldservice/views/fsm_order.xml
index abadf21883..9646f12810 100644
--- a/fieldservice/views/fsm_order.xml
+++ b/fieldservice/views/fsm_order.xml
@@ -41,18 +41,19 @@
                     </div>
                     <group>
                         <group>
-                            <field
-                                name="type"
-                                options="{'no_create': True, 'no_open': True}"
-                            />
                             <field
                                 name="template_id"
                                 groups="fieldservice.group_fsm_template"
                             />
+                            <field
+                                name="type"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
                             <field name="priority" widget="priority" />
                             <field
                                 name="tag_ids"
                                 widget="many2many_tags"
+                                groups="fieldservice.group_fsm_tag"
                                 options="{'color_field': 'color', 'no_create_edit': True}"
                             />
                         </group>
@@ -110,6 +111,7 @@
                                         name="category_ids"
                                         widget="many2many_tags"
                                         options="{'color_field': 'color'}"
+                                        groups="fieldservice.group_fsm_category"
                                     />
                                     <field name="request_early" />
                                     <field name="request_late" />
@@ -130,13 +132,15 @@
                                 >
                                     <tree>
                                         <field name="name" />
+                                        <field name="phone" />
+                                        <field name="email" />
                                         <field
                                             name="category_ids"
                                             widget="many2many_tags"
                                             options="{'color_field': 'color'}"
+                                            groups="fieldservice.group_fsm_category"
                                         />
-                                        <field name="phone" />
-                                        <field name="email" />
+                                        <field name="calendar_id" />
                                     </tree>
                                 </field>
                             </group>
@@ -296,6 +300,7 @@
                                     <field
                                         name="tag_ids"
                                         widget="many2many_tags"
+                                        groups="fieldservice.group_fsm_tag"
                                         options="{'color_field': 'color'}"
                                     />
                                 </div>
diff --git a/fieldservice/views/fsm_person.xml b/fieldservice/views/fsm_person.xml
index efac3ddef3..052d226996 100644
--- a/fieldservice/views/fsm_person.xml
+++ b/fieldservice/views/fsm_person.xml
@@ -12,6 +12,7 @@
                     name="category_ids"
                     widget="many2many_tags"
                     options="{'color_field': 'color'}"
+                    groups="fieldservice.group_fsm_category"
                 />
                 <field name="calendar_id" />
             </tree>
@@ -23,7 +24,7 @@
         <field name="arch" type="xml">
             <search string="Search FSM Workers">
                 <field name="name" />
-                <field name="category_ids" />
+                <field name="category_ids" groups="fieldservice.group_fsm_category" />
                 <field name="territory_ids" groups="fieldservice.group_fsm_territory" />
                 <field name="location_ids" />
             </search>
@@ -100,6 +101,7 @@
                                 name="category_ids"
                                 widget="many2many_tags"
                                 options="{'color_field': 'color'}"
+                                groups="fieldservice.group_fsm_category"
                             />
                             <label for="street" string="Address" />
                             <div class="o_address_format">
diff --git a/fieldservice/views/fsm_template.xml b/fieldservice/views/fsm_template.xml
index 6ab90b54f2..7acc04548a 100644
--- a/fieldservice/views/fsm_template.xml
+++ b/fieldservice/views/fsm_template.xml
@@ -7,6 +7,14 @@
             <tree>
                 <field name="name" />
                 <field name="duration" />
+                <field name="type_id" />
+                <field
+                    name="category_ids"
+                    widget="many2many_tags"
+                    options="{'color_field': 'color'}"
+                    groups="fieldservice.group_fsm_category"
+                />
+                <field name="team_id" groups="fieldservice.group_fsm_team" />
                 <field name="company_id" groups="base.group_multi_company" />
             </tree>
         </field>