From d6106d00c230045e48bd2556ab5f32aa12f9b733 Mon Sep 17 00:00:00 2001 From: Mario Arias Badila Date: Mon, 21 Oct 2024 10:50:58 -0600 Subject: [PATCH 1/2] Update hr_expense_sheet.py Use the correct partner, from current expense line from the report, not always the same partner from first expense line --- hr_expense_invoice/models/hr_expense_sheet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hr_expense_invoice/models/hr_expense_sheet.py b/hr_expense_invoice/models/hr_expense_sheet.py index 6ab00809e..1bd6e5a6c 100644 --- a/hr_expense_invoice/models/hr_expense_sheet.py +++ b/hr_expense_invoice/models/hr_expense_sheet.py @@ -37,7 +37,7 @@ def _do_create_moves(self): ) transfer_line = move.line_ids.filtered( lambda x: x.partner_id - == self.expense_line_ids.invoice_id.partner_id + == expense.invoice_id.partner_id ) (ap_lines + transfer_line).reconcile() return res From 8cc981fd251ccf0b158fb0087922ee60ef37f2a7 Mon Sep 17 00:00:00 2001 From: Mario Arias Badila Date: Mon, 21 Oct 2024 11:53:44 -0600 Subject: [PATCH 2/2] [FIX 17.0] hr_expense_invoice Fix ruff error on bad binding of "expense" variable on lambda function --- hr_expense_invoice/models/hr_expense_sheet.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hr_expense_invoice/models/hr_expense_sheet.py b/hr_expense_invoice/models/hr_expense_sheet.py index 1bd6e5a6c..c1af73dd4 100644 --- a/hr_expense_invoice/models/hr_expense_sheet.py +++ b/hr_expense_invoice/models/hr_expense_sheet.py @@ -36,8 +36,8 @@ def _do_create_moves(self): lambda x: x.display_type == "payment_term" ) transfer_line = move.line_ids.filtered( - lambda x: x.partner_id - == expense.invoice_id.partner_id + lambda x, partner=expense.invoice_id.partner_id: + x.partner_id == partner ) (ap_lines + transfer_line).reconcile() return res