From 7e5672f207d96ec9650adf4807df58a94bffbd04 Mon Sep 17 00:00:00 2001
From: EdgarRetes <edgar.retes24@gmail.com>
Date: Wed, 2 Oct 2024 16:38:03 -0600
Subject: [PATCH] [FIX] document_page_approval: Smart buttons

---
 document_page/models/document_page_history.py | 14 +++++------
 .../views/document_page_approval.xml          | 24 +++++++++----------
 2 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/document_page/models/document_page_history.py b/document_page/models/document_page_history.py
index 35ddb3922ff..426ee9adb76 100644
--- a/document_page/models/document_page_history.py
+++ b/document_page/models/document_page_history.py
@@ -66,11 +66,11 @@ def _get_diff(self, v1, v2):
                 context=True,
             )
 
-    # TODO: Replace for _compute_display_name
-    def name_get(self):
-        return [(rec.id, "%s #%i" % (rec.page_id.name, rec.id)) for rec in self]
+    # # TODO: Replace for _compute_display_name
+    # def name_get(self):
+    #     return [(rec.id, "%s #%i" % (rec.page_id.name, rec.id)) for rec in self]
 
-    @api.depends("page_id")
-    def _compute_display_name(self):
-        for rec in self:
-            rec.display_name = rec.id, "%s #%i" % (rec.page_id.name, rec.id)
+    # @api.depends("page_id")
+    # def _compute_display_name(self):
+    #     for rec in self:
+    #         rec.display_name = rec.id, "%s #%i" % (rec.page_id.name, rec.id)
diff --git a/document_page_approval/views/document_page_approval.xml b/document_page_approval/views/document_page_approval.xml
index a4b9c9a5a5f..00c6bf4b3ea 100644
--- a/document_page_approval/views/document_page_approval.xml
+++ b/document_page_approval/views/document_page_approval.xml
@@ -14,7 +14,7 @@
                         type="object"
                         string="Send to Review"
                         class="oe_highlight"
-                        invisible="not is_approval_required or not am_i_owner or state not in 'draft'"
+                        invisible="not is_approval_required or not am_i_owner or state != 'draft'"
                     />
                     <!-- approve if i am approver -->
                     <button
@@ -22,7 +22,7 @@
                         type="object"
                         string="Approve"
                         class="oe_highlight"
-                        invisible="not is_approval_required or not am_i_approver or state not in 'draft' or state not in 'to approve'"
+                        invisible="not is_approval_required or not am_i_approver or state != 'draft' or state != 'to approve'"
                     />
                     <!-- approve if it's not required and i am owner -->
                     <button
@@ -30,28 +30,28 @@
                         type="object"
                         string="Approve"
                         class="oe_highlight"
-                        invisible="is_approval_required or not am_i_owner or state not in 'draft' or state not in 'to approve'"
+                        invisible="is_approval_required or not am_i_owner or state != 'draft' or state != 'to approve'"
                     />
                     <!-- cancel if i am owner or approver -->
                     <button
                         name="action_cancel"
                         type="object"
                         string="Cancel"
-                        invisible="not am_i_owner or not am_i_approver and state not in 'draft' or state not in 'to approve'"
+                        invisible="(not am_i_owner or not am_i_approver) and (state != 'draft' or state != 'to approve')"
                     />
                     <!-- reopen if i am owner or approver -->
                     <button
                         name="action_draft"
                         type="object"
                         string="Back to draft"
-                        invisible="not am_i_owner or not am_i_approver and state not in 'cancelled'"
+                        invisible="(not am_i_owner or not am_i_approver) and (state != 'cancelled')"
                     />
                     <!-- cancel & reopen, if i am owner or approver -->
                     <button
                         name="action_draft"
                         type="object"
                         string="Back to draft"
-                        invisible="not am_i_owner or not am_i_approver and state not in 'to approve'"
+                        invisible="(not am_i_owner or not am_i_approver) and (state != 'to approve')"
                     />
                     <field name="am_i_owner" invisible="1" />
                     <field name="am_i_approver" invisible="1" />
@@ -69,30 +69,30 @@
                     <field
                         name="approved_uid"
                         readonly="1"
-                        invisible="state not in 'approved'"
+                        invisible="state != 'approved'"
                     />
                     <field
                         name="approved_date"
                         readonly="1"
-                        invisible="state not in 'approved'"
+                        invisible="state != 'approved'"
                     />
                 </group>
             </xpath>
             <!-- Readonly fields -->
             <field name="content" position="attributes">
-                <attribute name="readonly">state not in 'draft'
+                <attribute name="readonly">state != 'draft'
                 </attribute>
             </field>
             <field name="page_id" position="attributes">
-                <attribute name="readonly">state not in 'draft'
+                <attribute name="readonly">state != 'draft'
                 </attribute>
             </field>
             <field name="name" position="attributes">
-                <attribute name="readonly">state not in 'draft'
+                <attribute name="readonly">state != 'draft'
                 </attribute>
             </field>
             <field name="summary" position="attributes">
-                <attribute name="readonly">state not in 'draft'
+                <attribute name="readonly">state != 'draft'
                 </attribute>
             </field>
             <!-- Chatter -->