Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandoc-3.2-1-amd64.deb added by precommit hook #619

Closed
gurneyalex opened this issue Jun 27, 2024 · 5 comments · Fixed by #620
Closed

pandoc-3.2-1-amd64.deb added by precommit hook #619

gurneyalex opened this issue Jun 27, 2024 · 5 comments · Fixed by #620
Labels

Comments

@gurneyalex
Copy link
Member

gurneyalex commented Jun 27, 2024

Is it intended that the precommit hooks add pandoc-3.2-1-amd64.deb to the repositories?

I've seen this multiple time in PR reviews, and I'm wondering if this is intentional, or a blooper.

@pedrobaeza
Copy link
Member

See OCA/oca-addons-repo-template#262

@gurneyalex
Copy link
Member Author

Thanks for the pointer :)

@pedrobaeza
Copy link
Member

Closing this as redirected to the other issue.

@sbidoul
Copy link
Member

sbidoul commented Jul 3, 2024

I propose to keep this open, as there is a fix to do in both projects. Actually, in the project template, the .gitignore workaround of Alexandre should be sufficient, but we want to fix it here too.

@sbidoul sbidoul reopened this Jul 3, 2024
@nilshamerlinck
Copy link
Contributor

  • created oca-gen-addon-readme: delete pandoc installer #620
  • there's less than a dozen branches impacted branches for now, I would vote for a manual:
    • $ git filter-repo --path pandoc-*.deb --invert-paths --refs 17.0
    • force push
    • rebase on weblate side
  • open PRs will also have to rebase :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants