Add partner_base_multicompany_default_queue #712
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
force-pushed
the
add-partner_base_multicompany_default_queue
branch
3 times, most recently
from
ca86fb0
to
30cb398
Compare
leemannd
force-pushed
the
add-partner_base_multicompany_default_queue
branch
from
30cb398
to
faf0992
Compare
simahawk
reviewed
Oct 25, 2024
| "category": "Technical", | ||
| "website": "https://github.com/OCA/multi-company", | ||
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "maintainers": ["camptocamp"], |
Comment on lines
+13
to
+15
| """Keys to keep in context of stored jobs | ||
| Empty by default for backward compatibility. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """Keys to keep in context of stored jobs | |
| Empty by default for backward compatibility. | |
| """ |
There was a problem hiding this comment.
also, this override should be moved to res.partner
simahawk
requested changes
Oct 25, 2024
Comment on lines
+13
to
+15
| """Keys to keep in context of stored jobs | ||
| Empty by default for backward compatibility. | ||
| """ |
There was a problem hiding this comment.
also, this override should be moved to res.partner
|
|
||
| _inherit = "res.partner" | ||
|
|
||
| def _propagate_property_fields(self): |
There was a problem hiding this comment.
you miss a queue.job.function to be able to delay this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glue module inbetween
partner_base_multicompanyandqueue_job.The propagation of the fields can be costly given the amount of fields to be propagated and the amount of companies. By default the base module will make a write for each field to be propagated on each companies. With 4 fields and 4 companies it will trigger 16 writes which makes unusefull slownesses in the UI.
With this module, we want to make the propagation of the fields asynchronous with the creation of queue_jobs.