DELETE at volume has a payload "null" as a string

[ArturBaryla]

Hi - I have a problem with some actions at ODIM
ODIM is sending payload as invalid JSON with "null" as a string
When I am sending empty payload with DELETE at specifici volume:

ubuntu@ubuntu:~$ curl -X DELETE -k -u 'admin:Od!m12$4' https://10.91.209.202:45000/redfish/v1/Systems/27d60766-4e91-4ce9-9f33-cff0cad63e22:1/Storage/BMCStorage/Volumes/1 | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    69  100    69    0     0    104      0 --:--:-- --:--:-- --:--:--   104
{
  "error": {
    "code": "Base.1.0.InvalidPayload",
    "message": "Invalid Json"
  }
}

in debug mode I found that the request payload is "null" as a string - not empty payload.

[ehaligow]

Hi! I have a question regarding deleting a Volume: after deleting a Volume, the record is deleted from database; instead of it, a new one appear - SystemReset. This record is in database until
rediscovering system (according to method description, rediscovering system takes place whenever the restart event is detected in event service).
So, when I delete a Volume, and then trying to get it, it gets me NotFound response. But, if I get the list of all Volumes, the deleted Volume appears on that list. Is that the way it should work?

[ehaligow]

@bharath-b-hpe could you take a look at my question? I would really appreciate it.

[bharath-b-hpe]

Hi @ehaligow, Sorry missed the comment notification, let me check and get to you on the query.

[bharath-b-hpe]

Hello @ehaligow

Hope the slack conversation (https://odim.slack.com/archives/C01DG9MH479/p1621589474000300) answered your query.

Mentioning it here for future reference.

[bharath-b-hpe]

Hello @ArturBaryla

request payload passed to ODIM and from ODIM to plugin is of byte array type and the same encoded/decoded as json, which when empty will have nil value in golang. Could you please check if it's same at the device, where the issue is observed?

[bharath-b-hpe]

Hello @ArturBaryla

Its the behavior observed in golang, when http.NewRequest is created using bytes.NewBuffer(<data of type []byte>) API for reader, and byte data passed to bytes.NewBuffer is empty, payload in the new http request created is assigned with "{null}" as value.

[ehaligow]

Hi @bharath-b-hpe,
yes, the Slack conversation answered my query, thank you.
When it comes to your last comments, I investigated the problem a little bit and I think the problem is the RequestBody during Volume delete. The code for the DELETE is similar to CREATE and so is the method from systems.proto. We use VolumeRequest from systems.proto (for both Create and Delete) , here we have field RequestBody. For Delete the RequestBody is redundant (and null). I localy changed the code and for the Delete, I created DeleteVolumeRequest, this time without field RequestBody. And it seems to resolve the issue.

Could you confirm if I am right?
Regards,
Emilia