Skip to content

Commit 19ebc1e

Browse files
Su HuiSteve French
authored andcommitted
smb: client: fix possible double free in smb2_set_ea()
Clang static checker(scan-build) warning: fs/smb/client/smb2ops.c:1304:2: Attempt to free released memory. 1304 | kfree(ea); | ^~~~~~~~~ There is a double free in such case: 'ea is initialized to NULL' -> 'first successful memory allocation for ea' -> 'something failed, goto sea_exit' -> 'first memory release for ea' -> 'goto replay_again' -> 'second goto sea_exit before allocate memory for ea' -> 'second memory release for ea resulted in double free'. Re-initialie 'ea' to NULL near to the replay_again label, it can fix this double free problem. Fixes: 4f1fffa ("cifs: commands that are retried should have replay flag set") Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Su Hui <suhui@nfschina.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 8e929cb commit 19ebc1e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

fs/smb/client/smb2ops.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1158,7 +1158,7 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
11581158
struct cifs_fid fid;
11591159
unsigned int size[1];
11601160
void *data[1];
1161-
struct smb2_file_full_ea_info *ea = NULL;
1161+
struct smb2_file_full_ea_info *ea;
11621162
struct smb2_query_info_rsp *rsp;
11631163
int rc, used_len = 0;
11641164
int retries = 0, cur_sleep = 1;
@@ -1179,6 +1179,7 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
11791179
if (!utf16_path)
11801180
return -ENOMEM;
11811181

1182+
ea = NULL;
11821183
resp_buftype[0] = resp_buftype[1] = resp_buftype[2] = CIFS_NO_BUFFER;
11831184
vars = kzalloc(sizeof(*vars), GFP_KERNEL);
11841185
if (!vars) {

0 commit comments

Comments
 (0)