Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context menu): Implemented closing of context menu on outside click #4627

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(context menu): Implemented closing of context menu on outside click #4627

merged 3 commits into from
Jan 3, 2025

Conversation

Jaseel-trenser
Copy link
Contributor

@Jaseel-trenser Jaseel-trenser commented Dec 26, 2024 •
edited
Loading

Context

Changes & Results

Changes to the UIDialogService contract were made to handle outside clicks. The dialog provider accepts an onClickOutside parameter to handle such interactions, which was missing in UIDialogService.
By this change, the context menu is getting closed on an outside click.

oss_pr.mp4

Testing

  1. Draw an annotation
  2. Right-click on annotation to open context menu
  3. Perform another actions such as drawing another annotation, selecting a different tool, etc.
  4. Verify context menu is closing on outside click

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18
  • Browser: chrome

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2024 •
edited
Loading

✅ Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 48bc278
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/677805f724b0480008b59e71
😎 Deploy Preview https://deploy-preview-4627--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2024 •
edited
Loading

✅ Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 48bc278
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/677805f79e555400089525e0
😎 Deploy Preview https://deploy-preview-4627--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE self-requested a review January 3, 2025 15:41
IbrahimCSAE
IbrahimCSAE approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@IbrahimCSAE IbrahimCSAE merged commit 6b851df into OHIF:master Jan 3, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbrahimCSAE IbrahimCSAE IbrahimCSAE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The context menu is not closing when clicking outside of it
2 participants
@Jaseel-trenser @IbrahimCSAE