New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Grey hero variant: needs option to include a census logo #3488

Open

helenb opened this issue Feb 3, 2025 · 0 comments

Labels

Bug Community backlog High priority

helenb commented Feb 3, 2025 •

edited

Loading

Describe the bug

We need the option to pass in a census logo to the grey hero variant.

Figma link: https://www.figma.com/design/Yf4Cpxc8vYdoVrWcJojk2R/New-Website-Platform?m=auto&node-id=19-79&t=GY8DgHbUQ7u7hW0w-1

Expected behaviour / outcome

Have a new option to display the census logo or not

List the steps necessary to reproduce the bug

Review the options for the onsHero component - there is no option for the census logo.

Additional context

Current implementation in beta:

https://github.com/ONSdigital/dis-wagtail/blob/main/cms/jinja2/templates/pages/statistical_article_page.html#L29-L33, which includes https://github.com/ONSdigital/dis-wagtail/blob/main/cms/jinja2/templates/components/census/census-logo.html

What version of the ONS Design System are you using?

72.2.0

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

helenb added Bug Community backlog High priority labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment