gctp.c:257:81: error: passing argument 8 of ‘hinv_init’ from incompatible pointer type [-Wincompatible-pointer-types]

[rwmjones]

After fixing libdap, I get further compilation errors:

make[6]: Entering directory '/home/rjones/d/fedora/bes/rawhide/bes-3.21.0-46/modules/hdf5_handler/gctp/src'
gcc -DHAVE_CONFIG_H -I. -I../../../..  -I./../include/ -I/usr/include/cfitsio -I/usr/include/tirpc -Wno-vla -I/include -fpic -Wno-implicit-function-declaration -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64   -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -c -o gctp.o gctp.c
gctp.c: warning: -Wno-implicit-function-declaration detected - is this intentional ?
gctp.c: In function ‘gctp’:
gctp.c:257:81: error: passing argument 8 of ‘hinv_init’ from incompatible pointer type [-Wincompatible-pointer-types]
  257 |       hinv_init((int)*insys,(int)*inzone,dummy,(int)*indatum,fn27,fn83,&iflgval,(int *)hinv_trans);
      |                                                                                 ^~~~~~~~~~~~~~~~~
      |                                                                                 |
      |                                                                                 int *
In file included from ./../include/cproj_prototypes.h:32,
                 from ./../include/cproj.h:33,
                 from gctp.c:33:
./../include/gctp_prototypes.h:288:108: note: expected ‘int (**)(double,  double,  double *, double *)’ but argument is of type ‘int *’
  288 | int hinv_init(int insys, int inzone, double *inparm, int indatum, char *fn27, char *fn83, int *iflg, int (*hinv_trans[])(double, double, double*, double*));
      |                                                                                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gctp.c:260:81: error: passing argument 8 of ‘hinv_init’ from incompatible pointer type [-Wincompatible-pointer-types]
  260 |      hinv_init((int)*insys,(int)*inzone,inparm,(int)*indatum,fn27,fn83,&iflgval,(int *)hinv_trans);
      |                                                                                 ^~~~~~~~~~~~~~~~~
      |                                                                                 |
      |                                                                                 int *
./../include/gctp_prototypes.h:288:108: note: expected ‘int (**)(double,  double,  double *, double *)’ but argument is of type ‘int *’
  288 | int hinv_init(int insys, int inzone, double *inparm, int indatum, char *fn27, char *fn83, int *iflg, int (*hinv_trans[])(double, double, double*, double*));
      |                                                                                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gctp.c:319:84: error: passing argument 8 of ‘hfor_init’ from incompatible pointer type [-Wincompatible-pointer-types]
  319 |       hfor_init((int)*outsys,(int)*outzone,dummy,(int)*outdatum,fn27,fn83,&iflgval,(int *)hfor_trans);
      |                                                                                    ^~~~~~~~~~~~~~~~~
      |                                                                                    |
      |                                                                                    int *
./../include/gctp_prototypes.h:284:112: note: expected ‘int (**)(double,  double,  double *, double *)’ but argument is of type ‘int *’
  284 | int hfor_init(int outsys, int outzone, double *outparm, int outdatum, char *fn27, char *fn83, int *iflg, int (*hfor_trans[])(double, double, double *, double *));
      |                                                                                                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gctp.c:322:85: error: passing argument 8 of ‘hfor_init’ from incompatible pointer type [-Wincompatible-pointer-types]
  322 |      hfor_init((int)*outsys,(int)*outzone,outparm,(int)*outdatum,fn27,fn83,&iflgval,(int *)hfor_trans);
      |                                                                                     ^~~~~~~~~~~~~~~~~
      |                                                                                     |
      |                                                                                     int *
./../include/gctp_prototypes.h:284:112: note: expected ‘int (**)(double,  double,  double *, double *)’ but argument is of type ‘int *’
  284 | int hfor_init(int outsys, int outzone, double *outparm, int outdatum, char *fn27, char *fn83, int *iflg, int (*hfor_trans[])(double, double, double *, double *));
      |                                                                                                          ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[6]: *** [Makefile:665: gctp.o] Error 1

This is with:

libdap-3.21.0.27-1.fc41.x86_64
bes-3.21.0-46

[rwmjones]

Looking at this more closely, it seems related to hdf5. Fedora has hdf5-1.12.1-15.fc40.x86_64. Is a newer version needed?

Upstream there seems to be hdf5 1.12.3 described as "the last release for HDF5 1.12. Users should move to HDF5 1.14" and then hdf5 1.14.3.

Should we try 1.12.3 or move to 1.14.3? Is the move to 1.14 a large one?