Skip to content

Commit 19e8aa5

Browse files
authored
Merge pull request #391 from joakim-hove/remove-deck-usage
Remove GridManagere::createGrdecl() which accesses Deck directly
2 parents 9f66686 + c89ccb7 commit 19e8aa5

File tree

2 files changed

+0
-55
lines changed

2 files changed

+0
-55
lines changed

opm/grid/GridManager.cpp

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -173,57 +173,6 @@ namespace Opm
173173

174174
}
175175

176-
177-
void GridManager::createGrdecl(const Opm::Deck& deck, struct grdecl &grdecl)
178-
{
179-
// Extract data from deck.
180-
const std::vector<double>& zcorn = deck.getKeyword("ZCORN").getSIDoubleData();
181-
const std::vector<double>& coord = deck.getKeyword("COORD").getSIDoubleData();
182-
const int* actnum = NULL;
183-
if (deck.hasKeyword("ACTNUM")) {
184-
actnum = &(deck.getKeyword("ACTNUM").getIntData()[0]);
185-
}
186-
187-
std::array<int, 3> dims;
188-
if (deck.hasKeyword("DIMENS")) {
189-
const auto& dimensKeyword = deck.getKeyword("DIMENS");
190-
dims[0] = dimensKeyword.getRecord(0).getItem(0).get< int >(0);
191-
dims[1] = dimensKeyword.getRecord(0).getItem(1).get< int >(0);
192-
dims[2] = dimensKeyword.getRecord(0).getItem(2).get< int >(0);
193-
} else if (deck.hasKeyword("SPECGRID")) {
194-
const auto& specgridKeyword = deck.getKeyword("SPECGRID");
195-
dims[0] = specgridKeyword.getRecord(0).getItem(0).get< int >(0);
196-
dims[1] = specgridKeyword.getRecord(0).getItem(1).get< int >(0);
197-
dims[2] = specgridKeyword.getRecord(0).getItem(2).get< int >(0);
198-
} else {
199-
OPM_THROW(std::runtime_error, "Deck must have either DIMENS or SPECGRID.");
200-
}
201-
202-
// Collect in input struct for preprocessing.
203-
204-
grdecl.zcorn = &zcorn[0];
205-
grdecl.coord = &coord[0];
206-
grdecl.actnum = actnum;
207-
grdecl.dims[0] = dims[0];
208-
grdecl.dims[1] = dims[1];
209-
grdecl.dims[2] = dims[2];
210-
211-
if (deck.hasKeyword("MAPAXES")) {
212-
const auto& mapaxesKeyword = deck.getKeyword("MAPAXES");
213-
const auto& mapaxesRecord = mapaxesKeyword.getRecord(0);
214-
215-
// memleak alert: here we need to make sure that C code
216-
// can properly take ownership of the grdecl.mapaxes
217-
// object. if it is not freed, it will result in a
218-
// memleak...
219-
double *cWtfMapaxes = static_cast<double*>(malloc(sizeof(double)*mapaxesRecord.size()));
220-
for (unsigned i = 0; i < mapaxesRecord.size(); ++i)
221-
cWtfMapaxes[i] = mapaxesRecord.getItem(i).getSIDouble(0);
222-
grdecl.mapaxes = cWtfMapaxes;
223-
} else
224-
grdecl.mapaxes = NULL;
225-
226-
}
227176
#endif
228177

229178

opm/grid/GridManager.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ namespace Opm
8080
/// to make it clear that we are returning a C-compatible struct.
8181
const UnstructuredGrid* c_grid() const;
8282

83-
#if HAVE_ECL_INPUT
84-
static void createGrdecl(const Opm::Deck& deck, struct grdecl &grdecl);
85-
#endif
86-
8783
private:
8884
// Disable copying and assignment.
8985
GridManager(const GridManager& other);

0 commit comments

Comments
 (0)