#1253 Remove usage of constants not available for PHP 7 version

Author: j3nsch

library/Application/Console/Model/EnrichmentDeleteCommand.php

@@ -79,14 +79,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         if ($key === null) {
             $output->writeln('<error>Enrichment key is required</error>');
-            return self::FAILURE;
+            return 1;
         }
 
         $enrichment = EnrichmentKey::fetchByName($key);
 
         if ($enrichment === null) {
             $output->writeln("<error>Enrichment key \"{$key}\" not found</error>");
-            return self::FAILURE;
+            return 1;
         }
 
         if (! $input->getOption(self::OPTION_FORCE)) {
@@ -96,7 +96,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             if (! $question->ask($input, $output, $confirmation)) {
                 $output->writeln("Not removing enrichment key \"{$key}\".");
-                return self::SUCCESS;
+                return 0;
             }
         }
 
@@ -107,6 +107,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $helper = new Admin_Model_EnrichmentKeys();
         $helper->removeTranslations($key);
 
-        return self::SUCCESS;
+        return 0;
     }
 }

library/Application/Console/Model/EnrichmentExportCommand.php

@@ -86,14 +86,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
                 if ($enrichment === null) {
                     $output->writeln("<error>Enrichment key \"{$key}\" not found</error>");
-                    return self::FAILURE;
+                    return 1;
                 }
             }
         }
 
         if (count($keys) === 0) {
             $output->writeln("<info>No enrichment keys found</info>");
-            return self::SUCCESS;
+            return 0;
         }
 
         $helper = new Admin_Model_EnrichmentKeys();
@@ -123,6 +123,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             file_put_contents($outputFile, $yaml);
         }
 
-        return self::SUCCESS;
+        return 0;
     }
 }

library/Application/Console/Model/EnrichmentImportCommand.php

@@ -66,19 +66,19 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         if (! file_exists($file)) {
             $output->writeln('<fg=red>Input file not found</>');
-            return self::FAILURE;
+            return 1;
         }
 
         if (! is_readable($file)) {
             $output->writeln('<fg=red>Input file not readable</>');
-            return self::FAILURE;
+            return 1;
         }
 
         $importer = new Application_Configuration_EnrichmentConfigImporter();
         $importer->setOutput($output);
 
         $importer->import($file);
 
-        return self::SUCCESS;
+        return 0;
     }
 }

library/Application/Console/Model/EnrichmentListCommand.php

@@ -76,6 +76,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             ->setRows($rows);
         $table->render();
 
-        return self::SUCCESS;
+        return 0;
     }
 }

library/Application/Console/Model/EnrichmentRenameCommand.php

@@ -72,28 +72,28 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         if ($key === null) {
             $output->writeln('<error>Enrichment key is required.</error></>');
-            return self::FAILURE;
+            return 1;
         }
 
         $newKey = $input->getArgument(self::ARGUMENT_NEW_KEY);
 
         if ($newKey === null) {
             $output->writeln('<error>New enrichment key name is required.</error></>');
-            return self::FAILURE;
+            return 1;
         }
 
         $enrichment = EnrichmentKey::fetchByName($key);
 
         if ($enrichment === null) {
             $output->writeln("<error>Enrichment key \"{$key}\" not found.</error>");
-            return self::FAILURE;
+            return 1;
         }
 
         $newEnrichment = EnrichmentKey::fetchByName($newKey);
 
         if ($newEnrichment !== null) {
             $output->writeln("<error>Enrichment key \"{$newKey}\" already exists.</error>");
-            return self::FAILURE;
+            return 1;
         }
 
         $output->writeln("Renaming key \"{$key}\" to \"{$newKey}\".");
@@ -105,6 +105,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $helper = new Admin_Model_EnrichmentKeys();
         $helper->createTranslations($newKey, $key);
 
-        return self::SUCCESS;
+        return 0;
     }
 }